Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process.config.variables.arm_version incorrect in armv7 #4531

Closed
igorklopov opened this issue Jan 4, 2016 · 5 comments
Closed

process.config.variables.arm_version incorrect in armv7 #4531

igorklopov opened this issue Jan 4, 2016 · 5 comments
Labels
arm Issues and PRs related to the ARM platform. build Issues and PRs related to build files or the CI. confirmed-bug Issues with confirmed bugs.

Comments

@igorklopov
Copy link
Contributor

Armv7 machine (Scaleway C1). I install node from node-v4.2.4-linux-armv7l.tar.gz. Run node -p process.config.variables.arm_version. It returns incorrect value 6. Expected correct value 7. When node 4.2.4 is compiled from source, it gives correct value 7.

Run readelf -A /usr/bin/node | grep CPU_arch:. Gives correct value "v7". So the binary is armv7 but process.config seems incorrect.

The gist https://gist.github.com/igorklopov/8edef2199419e3fb9c99 shows that it started in 4.1.0. Node 4.0.0 was not affected.

@mscdex mscdex added build Issues and PRs related to build files or the CI. arm Issues and PRs related to the ARM platform. labels Jan 4, 2016
@rvagg
Copy link
Member

rvagg commented Jan 5, 2016

Thanks for reporting this @igorklopov, I'm a little surprised this went unnoticed for so long. I can confirm your analysis and I've traced it to the fact that we're using Raspbian to get gcc 4.8 on the machine we're using to compile these binaries even though it's a vanilla Debian Wheezy armhf base, and of course Raspbian is armv6 so we get #define __ARM_ARCH 6 from the compiler...

Doh!

Which means we need to go back to finding a Wheezy armhf gcc 4.8(+) source or build one ourselves (which I think I did in the past but that's such a nightmare).

/cc @nodejs/build

@XadillaX
Copy link
Contributor

I will try to take this issue and fix.

@interpretor
Copy link

This really is a problem, as without any correct architecture information I can not load the correct prebuilt binaries.
Any suggestions for a workaround that does not involve bash scripting?

@Trott
Copy link
Member

Trott commented Aug 10, 2017

Any chance someone is in a position to move this forward? Or should we label this stalled and/or help wanted?

@bnoordhuis
Copy link
Member

Moving to nodejs/build#829.

malept added a commit to electron/packager that referenced this issue Jan 1, 2018
Several versions of Node for armv7l incorrectly identify as
`arm_version: '6'`.

See: nodejs/node#4531 and related
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm Issues and PRs related to the ARM platform. build Issues and PRs related to build files or the CI. confirmed-bug Issues with confirmed bugs.
Projects
None yet
Development

No branches or pull requests

7 participants