Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python tools/test.py -J --mode=release parallel/test-* #44330

Closed
ronag opened this issue Aug 21, 2022 · 9 comments
Closed

python tools/test.py -J --mode=release parallel/test-* #44330

ronag opened this issue Aug 21, 2022 · 9 comments
Labels
test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.

Comments

@ronag
Copy link
Member

ronag commented Aug 21, 2022

python tools/test.py -J --mode=release parallel/test-* doesn't seem to work anymore?

node$ python tools/test.py -J --mode=release parallel/test-*
  File "tools/test.py", line 230
    print(f" failed {len([i for i in outputs if i.UnexpectedOutput()]) + 1} out of {self.measure_flakiness + 1}")
@ronag
Copy link
Member Author

ronag commented Aug 21, 2022

@Trott

@MoLow
Copy link
Member

MoLow commented Aug 21, 2022

I had to upgrade my python version for it to work properly.
What version are you using?

@MoLow MoLow added build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. and removed build Issues and PRs related to build files or the CI. labels Aug 21, 2022
@ronag
Copy link
Member Author

ronag commented Aug 21, 2022

2.7

@MoLow
Copy link
Member

MoLow commented Aug 21, 2022

I think #43954 made tools/test.py work only on python 3
@ronag can you confirm by running python3 tools/test.py -J --mode=release parallel/test-*?

@MoLow
Copy link
Member

MoLow commented Aug 21, 2022

NVM, I reproduced locally:

python2 --version
Python 2.7.18

python2 tools/test.py -J message
  File "tools/test.py", line 230
    print(f" failed {len([i for i in outputs if i.UnexpectedOutput()]) + 1} out of {self.measure_flakiness + 1}")
                                                                                                               ^
SyntaxError: invalid syntax

and

python --version
Python 3.9.13

python tools/test.py -J message
[00:07|% 100|+  66|-   0]: Done

@MoLow
Copy link
Member

MoLow commented Aug 21, 2022

CC @aduh95
I am not sure how important it is to support python 2

@ronag
Copy link
Member Author

ronag commented Aug 21, 2022

Thanks! That fixed it.

@ronag ronag closed this as completed Aug 21, 2022
@Trott
Copy link
Member

Trott commented Aug 21, 2022

I am not sure how important it is to support python 2

We dropped support for Python 2 some time ago. It has been EOL for a while. @nodejs/python might have more context to supply (especially @cclauss).

@cclauss
Copy link
Contributor

cclauss commented Aug 21, 2022

Python 2 died 963 days ago on 1/1/2020. No security updates since then -- It should no longer be trusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

No branches or pull requests

4 participants