Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add performance degradation warning on --enable-source-maps option #43812

Closed
saurabhdaware opened this issue Jul 13, 2022 · 1 comment · Fixed by #43817
Closed

Add performance degradation warning on --enable-source-maps option #43812

saurabhdaware opened this issue Jul 13, 2022 · 1 comment · Fixed by #43817
Labels
doc Issues and PRs related to the documentations.

Comments

@saurabhdaware
Copy link
Contributor

Affected URL(s)

No response

Description of the problem

There is an open issue regarding --enable-source-maps slowing down the performance with large bundles #41541

This can cause CPU Utilisation bumps or memory bumps if used in larger applications right now. I believe, we should mention this as a warning in documentation of --enable-source-maps because there isn't visibility on that issue apart from the particular github issue itself and it can cause some failures in production applications (it did for us because of CPU utilisation bumps)

Source map documentation: https://nodejs.org/api/cli.html#--enable-source-maps

I'll be happy to contribute if you all agree with this.

Thanks for all the work on nodejs 🎉

@saurabhdaware saurabhdaware added the doc Issues and PRs related to the documentations. label Jul 13, 2022
@aduh95
Copy link
Contributor

aduh95 commented Jul 13, 2022

Go for it! A rule of thumb is that you never have to ask permission for improving the docs because we can always do better – and we can discuss the specific details on the PR review, which tends to be more productive discussion than an issue thread for this kind of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
2 participants