Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node higher debug level desirable - common.gypi #4130

Closed
diegosanchez opened this issue Dec 3, 2015 · 3 comments
Closed

node higher debug level desirable - common.gypi #4130

diegosanchez opened this issue Dec 3, 2015 · 3 comments
Labels
build Issues and PRs related to build files or the CI.

Comments

@diegosanchez
Copy link

Because an issue with openssl Issue#4121 @bnoordhuis found useful to have a backtrace with full information.

In order to supply it I had to change level of debug of common.gypi file from -g to -g3.

Shall we add it as default configuration for common.gypi?

@Fishrock123 Fishrock123 added the build Issues and PRs related to build files or the CI. label Dec 3, 2015
@Fishrock123
Copy link
Contributor

@diegosanchez could you open a PR? we can probably discuss it easier like that. :)

@diegosanchez diegosanchez changed the title node debug level desirable - common.gypi node higher debug level desirable - common.gypi Dec 3, 2015
@diegosanchez
Copy link
Author

I thought the debug information provided by -gwasn't enough to have a full backtrace but it's. So that I wanted to change:
'cflags': [ '-g', '-O0' ], for 'cflags': [ '-g3', '-O0' ],

But it doesn't make sense.
My bad.
Lets close the issue

@evanlucas
Copy link
Contributor

closing at the request of @diegosanchez.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

No branches or pull requests

3 participants