-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential Regression/Change: Connection doesn't reset on HEAD #34758
Labels
http
Issues or PRs related to the http subsystem.
Comments
This was referenced May 27, 2022
This was referenced Sep 29, 2022
This was referenced Oct 5, 2022
This was referenced Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What steps will reproduce the bug?
HEAD request to server that responds with
Content-Length
orContent-Encoding
, for example wikipedia.org, or any S3 file.How often does it reproduce? Is there a required condition?
Always, if the response headers contain payload headers (
content-length
,content-encoding
).What is the expected behavior?
According to #12396, this is a bug, and we would expect all HEAD requests to close the socket.
IMHO, the current behavior is equally compliant.
What do you see instead?
Keep-alive is respected, socket remains open for multiple requests.
Additional information
I don't think this is actually a bug, I just wanted to draw attention to the fact that either the behavior changed without people noticing since 2017, or the original reporter was testing exclusively against servers that don't report payloads for HEAD (which includes node).
This is also the thrust of my PR to add those headers to node's server: #34231
And related issue: #28438
The text was updated successfully, but these errors were encountered: