Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: missing single quotes in api/tls.md for v10.x #33631

Closed
mscdex opened this issue May 29, 2020 · 6 comments
Closed

doc: missing single quotes in api/tls.md for v10.x #33631

mscdex opened this issue May 29, 2020 · 6 comments
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. tls Issues and PRs related to the tls subsystem.

Comments

@mscdex
Copy link
Contributor

mscdex commented May 29, 2020

  • Version: v10.x
  • Platform: n/a
  • Subsystem: doc, tls

The minVersion and maxVersion descriptions in the tls docs are missing single quotes before TLSv1.2. The docs for newer branches do not have this issue.
@mscdex mscdex added tls Issues and PRs related to the tls subsystem. doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. v10.x labels May 29, 2020
@sparsh-99
Copy link

Assign it to me... I am already working on this!!!

@sparsh-99
Copy link

@mscdex Where I can find tls.md file of v10.x?

@sam-github
Copy link
Contributor

https://github.com/nodejs/node/blob/v10.x-staging/doc/api/tls.md

@sparsh-99
Copy link

#33641 Successfully opened PL to this issue
Thank You @mscdex @sam-github
This is my first PL towards the Open Source Projects

@sparsh-99 sparsh-99 mentioned this issue Jun 15, 2020
Closed
2 tasks
@dnswd
Copy link

dnswd commented Aug 4, 2020

This issue is solved on 00f04e3. Consider closing this issue @mscdex .

@gireeshpunathil
Copy link
Member

issue was addressed sometime back, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sam-github @mscdex @gireeshpunathil @dnswd @sparsh-99