Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test addons on windows test-ci #3339

Closed
Fishrock123 opened this issue Oct 13, 2015 · 3 comments
Closed

Test addons on windows test-ci #3339

Fishrock123 opened this issue Oct 13, 2015 · 3 comments
Labels
build Issues and PRs related to build files or the CI. duplicate Issues and PRs that are duplicates of other issues or PRs. windows Issues and PRs related to the Windows platform.

Comments

@Fishrock123
Copy link
Contributor

Looks like window's test-ci doesn't include addons, where makefile does.

Do we have any idea what would be necessary to run these on the windows CI? It seems fairly important.

Related: #2830

cc @nodejs/build

@Fishrock123 Fishrock123 added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. labels Oct 13, 2015
@bnoordhuis
Copy link
Member

Also related: #2428.

I'm not sure if batch file scripting is flexible enough to handle building add-ons, in particular ones scraped from the documentation. We'd probably either need to build them unconditionally or implement a poor man's make in JS or python.

For the CI, it's fine to build them from scratch every time. It's kind of annoying when developing locally though.

@mathiask88
Copy link
Contributor

For the sake of completeness: #2537

@Fishrock123 Fishrock123 added the duplicate Issues and PRs that are duplicates of other issues or PRs. label Oct 21, 2015
@Fishrock123
Copy link
Contributor Author

@mathiask88 Ah good catch :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. duplicate Issues and PRs that are duplicates of other issues or PRs. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

3 participants