Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominating @Himself65 as a collaborator #32441

Closed
gabrielschulhof opened this issue Mar 23, 2020 · 16 comments
Closed

Nominating @Himself65 as a collaborator #32441

gabrielschulhof opened this issue Mar 23, 2020 · 16 comments
Labels
meta Issues and PRs related to the general management of the project. tsc-agenda Issues and PRs to discuss during the meetings of the TSC.

Comments

@gabrielschulhof
Copy link
Contributor

I would like to nominate @himself65 as a collaborator.

They have contributed amply to the project: https://github.com/search?q=org%3Anodejs+involves%3AHimself65

@gabrielschulhof gabrielschulhof added the meta Issues and PRs related to the general management of the project. label Mar 23, 2020
@mhdawson
Copy link
Member

+1

1 similar comment
@antsmartian
Copy link
Contributor

+1

@juanarbol
Copy link
Member

+1

I thought he already was collaborator

@gabrielschulhof
Copy link
Contributor Author

I think this means the nomination has passed 🎉 Yaaay!

@gabrielschulhof
Copy link
Contributor Author

@himself65 can you please read https://github.com/nodejs/node/blob/master/onboarding.md and make sure you have two-factor authentication turned on for GitHub?

@himself65
Copy link
Member

himself65 commented Mar 31, 2020

@gabrielschulhof thank you for nominating me.

and I've read the doc and enabled two-factor auth

@addaleax addaleax added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Mar 31, 2020
@addaleax
Copy link
Member

Also adding this to the tsc-agenda for announcement, as per our rules.

(Congratulations! @himself65! 🎉)

@gabrielschulhof
Copy link
Contributor Author

@himself65 is there a good time for you to meet over Hangouts next week so we can go through the onboarding doc? I'm in the Pacific Time Zone.

@himself65
Copy link
Member

@gabrielschulhof
I’m in GMT+8, and available during 11:00 - 1:00(next day)

@gabrielschulhof
Copy link
Contributor Author

@himself65 how about this:

onboarding time

I'll send a hangout link to the email address from which you commit.

@gabrielschulhof
Copy link
Contributor Author

Oh, wait, you said 11:00 🤦

@gabrielschulhof
Copy link
Contributor Author

@himself65 fixed. Sorry!

onboarding time

@himself65
Copy link
Member

ok👍

@gabrielschulhof
Copy link
Contributor Author

@himself65 Excellent! I'll send you the hangout link when the time comes.

@himself65
Copy link
Member

Send me the link to [email protected].

@himself65
Copy link
Member

Landed in 934ef43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project. tsc-agenda Issues and PRs to discuss during the meetings of the TSC.
Projects
None yet
Development

No branches or pull requests

6 participants