Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compilation failure in tls_wrap.cc: 'SSL_CTX_set_keylog_callback' was not declared in this scope #31963

Closed
gireeshpunathil opened this issue Feb 26, 2020 · 2 comments
Labels
invalid Issues and PRs that are invalid.

Comments

@gireeshpunathil
Copy link
Member

  • Version: master, sharedlibs_openssl
  • Platform: linux
  • Subsystem: crypto
22:36:43   ccache g++ -o /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj.target/node_lib/gen/node_javascript.o /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj/gen/node_javascript.cc '-DNODE_ARCH="x64"' '-DNODE_PLATFORM="linux"' '-DNODE_WANT_INTERNALS=1' '-DV8_DEPRECATION_WARNINGS=1' '-DNODE_OPENSSL_SYSTEM_CERT_PATH=""' '-DHAVE_INSPECTOR=1' '-D__POSIX__' '-DNODE_USE_V8_PLATFORM=1' '-DNODE_HAVE_I18N_SUPPORT=1' '-DNODE_HAVE_SMALL_ICU=1' '-DHAVE_OPENSSL=1' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' '-DHTTP_PARSER_STRICT=0' '-D_LARGEFILE_SOURCE' '-D_FILE_OFFSET_BITS=64' '-D_POSIX_C_SOURCE=200112' '-DNGHTTP2_STATICLIB' -I/opt/openssl-1.1.0j/include -I../src -I/home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj/gen -I/home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj/gen/include -I/home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj/gen/src -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common -I../deps/zlib -I../deps/http_parser -I../deps/cares/include -I../deps/uv/include -I../deps/nghttp2/lib/includes -I../deps/brotli/c/include  -pthread -Wall -Wextra -Wno-unused-parameter -m64 -Wall -Wextra -Wno-unused-parameter -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/.deps//home/iojs/build/workspace/node-test-commit-linux-containered/out/Release/obj.target/node_lib/gen/node_javascript.o.d.raw   -c
22:36:46 ../src/tls_wrap.cc: In static member function 'static void node::TLSWrap::EnableKeylogCallback(const v8::FunctionCallbackInfo<v8::Value>&)':
22:36:46 ../src/tls_wrap.cc:844:3: error: 'SSL_CTX_set_keylog_callback' was not declared in this scope
22:36:46    SSL_CTX_set_keylog_callback(wrap->sc_->ctx_.get(),
22:36:46    ^~~~~~~~~~~~~~~~~~~~~~~~~~~
22:36:46 ../src/tls_wrap.cc:844:3: note: suggested alternative: 'SSL_CTX_set_info_callback'
22:36:46    SSL_CTX_set_keylog_callback(wrap->sc_->ctx_.get(),
22:36:46    ^~~~~~~~~~~~~~~~~~~~~~~~~~~
22:36:46    SSL_CTX_set_info_callback

https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_openssl110_x64/18273/console

cc @nodejs/crypto

@richardlau
Copy link
Member

@gireeshpunathil that’s a Node.js 10 PR, not a master CI. This particular job is for #31582 and the failure noted in #31582 (comment).

@gireeshpunathil
Copy link
Member Author

ah, ok; thanks @richardlau for the clarification.
I did not pay attention to the branch, was under the impression that node-test-pull-request is always exercised for master!

@addaleax addaleax added the invalid Issues and PRs that are invalid. label Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Issues and PRs that are invalid.
Projects
None yet
Development

No branches or pull requests

3 participants