Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test-http2-ping-settings-heapdump #31962

Closed
gireeshpunathil opened this issue Feb 26, 2020 · 3 comments
Closed

Investigate flaky test-http2-ping-settings-heapdump #31962

gireeshpunathil opened this issue Feb 26, 2020 · 3 comments
Labels
invalid Issues and PRs that are invalid.

Comments

@gireeshpunathil
Copy link
Member

  • Version: master, sharedlib_debug
  • Platform: linux-cotainerized
  • Subsystem: http2
09:12:46 not ok 1286 parallel/test-http2-ping-settings-heapdump
09:12:46   ---
09:12:46   duration_ms: 0.726
09:12:46   severity: crashed
09:12:46   exitcode: -4
09:12:46   stack: |-
09:12:46     
09:12:46     
09:12:46     #
09:12:46     # Fatal error in ../deps/v8/src/heap/heap-inl.h, line 245
09:12:46     # Debug check failed: AllowHeapAllocation::IsAllowed().
09:12:46     #
09:12:46     #
09:12:46     #
09:12:46     #FailureMessage Object: 0x7ffd458b8350
09:12:46      1: 0x55bb6f292c41 node::DumpBacktrace(_IO_FILE*) [out/Debug/node]
09:12:46      2: 0x55bb6f41aaeb  [out/Debug/node]
09:12:46      3: 0x55bb6f41ab0b  [out/Debug/node]
09:12:46      4: 0x55bb70d08666 V8_Fatal(char const*, int, char const*, ...) [out/Debug/node]
09:12:46      5: 0x55bb70d08695  [out/Debug/node]
09:12:46      6: 0x55bb6f89ef58 v8::internal::HeapObject v8::internal::Heap::AllocateRawWith<(v8::internal::Heap::AllocationRetryMode)1>(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [out/Debug/node]
09:12:46      7: 0x55bb6f8a57b3 v8::internal::Factory::NewMap(v8::internal::InstanceType, int, v8::internal::ElementsKind, int) [out/Debug/node]
09:12:46      8: 0x55bb6fbb5216 v8::internal::Map::RawCopy(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Map>, int, int) [out/Debug/node]
09:12:46      9: 0x55bb6fbb5812 v8::internal::Map::CopyDropDescriptors(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Map>) [out/Debug/node]
09:12:46     10: 0x55bb6fbbacac v8::internal::Map::ShareDescriptor(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Map>, v8::internal::Handle<v8::internal::DescriptorArray>, v8::internal::Descriptor*) [out/Debug/node]
09:12:46     11: 0x55bb6fbbb1b5 v8::internal::Map::CopyAddDescriptor(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Map>, v8::internal::Descriptor*, v8::internal::TransitionFlag) [out/Debug/node]
09:12:46     12: 0x55bb6fbbb38f v8::internal::Map::CopyWithField(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Map>, v8::internal::Handle<v8::internal::Name>, v8::internal::Handle<v8::internal::FieldType>, v8::internal::PropertyAttributes, v8::internal::PropertyConstness, v8::internal::Representation, v8::internal::TransitionFlag) [out/Debug/node]
09:12:46     13: 0x55bb6fbbef81 v8::internal::Map::TransitionToDataProperty(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Map>, v8::internal::Handle<v8::internal::Name>, v8::internal::Handle<v8::internal::Object>, v8::internal::PropertyAttributes, v8::internal::PropertyConstness, v8::internal::StoreOrigin) [out/Debug/node]
09:12:46     14: 0x55bb6fb9de02 v8::internal::LookupIterator::PrepareTransitionToDataProperty(v8::internal::Handle<v8::internal::JSReceiver>, v8::internal::Handle<v8::internal::Object>, v8::internal::PropertyAttributes, v8::internal::StoreOrigin) [out/Debug/node]
09:12:46     15: 0x55bb6fbf1bf3 v8::internal::Object::AddDataProperty(v8::internal::LookupIterator*, v8::internal::Handle<v8::internal::Object>, v8::internal::PropertyAttributes, v8::Maybe<v8::internal::ShouldThrow>, v8::internal::StoreOrigin) [out/Debug/node]
09:12:46     16: 0x55bb6fbf29aa v8::internal::Object::SetProperty(v8::internal::LookupIterator*, v8::internal::Handle<v8::internal::Object>, v8::internal::StoreOrigin, v8::Maybe<v8::internal::ShouldThrow>) [out/Debug/node]
09:12:46     17: 0x55bb6fddea85 v8::internal::Runtime::SetObjectProperty(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, v8::internal::StoreOrigin, v8::Maybe<v8::internal::ShouldThrow>) [out/Debug/node]
09:12:46     18: 0x55bb6f5d0a09 v8::Object::Set(v8::Local<v8::Context>, v8::Local<v8::Value>, v8::Local<v8::Value>) [out/Debug/node]
09:12:46     19: 0x55bb6f261a93 node::AsyncWrap::EmitDestroy() [out/Debug/node]
09:12:46     20: 0x55bb6f264534 node::AsyncWrap::~AsyncWrap() [out/Debug/node]
09:12:46     21: 0x55bb6f3c2aae node::http2::Http2Session::Http2Settings::~Http2Settings() [out/Debug/node]
09:12:46     22: 0x55bb6f3c2aca node::http2::Http2Session::Http2Settings::~Http2Settings() [out/Debug/node]
09:12:46     23: 0x55bb6f28bbe3 node::BaseObject::decrease_refcount() [out/Debug/node]
09:12:46     24: 0x55bb6f3ad8eb node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false>::~BaseObjectPtrImpl() [out/Debug/node]
09:12:46     25: 0x55bb6f3bdf60 void std::_Destroy<node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false> >(node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false>*) [out/Debug/node]
09:12:46     26: 0x55bb6f3bc8f7 void std::_Destroy_aux<false>::__destroy<node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false>*>(node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false>*, node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false>*) [out/Debug/node]
09:12:46     27: 0x55bb6f3ba6b8 void std::_Destroy<node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false>*>(node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false>*, node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false>*) [out/Debug/node]
09:12:46     28: 0x55bb6f3b899e void std::_Destroy<node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false>*, node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false> >(node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false>*, node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false>*, std::allocator<node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false> >&) [out/Debug/node]
09:12:46     29: 0x55bb6f3b511d std::deque<node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false>, std::allocator<node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false> > >::_M_destroy_data_aux(std::_Deque_iterator<node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false>, node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false>&, node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false>*>, std::_Deque_iterator<node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false>, node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false>&, node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false>*>) [out/Debug/node]
09:12:46     30: 0x55bb6f3b05b6 std::deque<node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false>, std::allocator<node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false> > >::_M_destroy_data(std::_Deque_iterator<node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false>, node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false>&, node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false>*>, std::_Deque_iterator<node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false>, node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false>&, node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false>*>, std::allocator<node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false> > const&) [out/Debug/node]
09:12:46     31: 0x55bb6f3aca4a std::deque<node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false>, std::allocator<node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false> > >::~deque() [out/Debug/node]
09:12:46     32: 0x55bb6f3ab66c std::queue<node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false>, std::deque<node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false>, std::allocator<node::BaseObjectPtrImpl<node::http2::Http2Session::Http2Settings, false> > > >::~queue() [out/Debug/node]
09:12:46     33: 0x55bb6f38564a node::http2::Http2Session::~Http2Session() [out/Debug/node]
09:12:46     34: 0x55bb6f3856f8 node::http2::Http2Session::~Http2Session() [out/Debug/node]
09:12:46     35: 0x55bb6f2708ee node::BaseObject::OnGCCollect() [out/Debug/node]
09:12:46     36: 0x55bb6f2707f4 node::BaseObject::MakeWeak()::{lambda(v8::WeakCallbackInfo<node::BaseObject> const&)#1}::operator()(v8::WeakCallbackInfo<node::BaseObject> const&) const [out/Debug/node]
09:12:46     37: 0x55bb6f270814 node::BaseObject::MakeWeak()::{lambda(v8::WeakCallbackInfo<node::BaseObject> const&)#1}::_FUN(v8::WeakCallbackInfo<node::BaseObject> const&) [out/Debug/node]
09:12:46     38: 0x55bb6f87e9f7 unsigned long v8::internal::GlobalHandles::InvokeFirstPassWeakCallbacks<v8::internal::GlobalHandles::Node>(std::vector<std::pair<v8::internal::GlobalHandles::Node*, v8::internal::GlobalHandles::PendingPhantomCallback>, std::allocator<std::pair<v8::internal::GlobalHandles::Node*, v8::internal::GlobalHandles::PendingPhantomCallback> > >*) [out/Debug/node]
09:12:46     39: 0x55bb6f87f3b2 v8::internal::GlobalHandles::InvokeFirstPassWeakCallbacks() [out/Debug/node]
09:12:46     40: 0x55bb6f8f8ff8 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [out/Debug/node]
09:12:46     41: 0x55bb6f8f9d58 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [out/Debug/node]
09:12:46     42: 0x55bb6f8fd552 v8::internal::Heap::PreciseCollectAllGarbage(int, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [out/Debug/node]
09:12:46     43: 0x55bb6fcf315d v8::internal::HeapSnapshotGenerator::GenerateSnapshot() [out/Debug/node]
09:12:46     44: 0x55bb6fcdfe11 v8::internal::HeapProfiler::TakeSnapshot(v8::ActivityControl*, v8::HeapProfiler::ObjectNameResolver*) [out/Debug/node]
09:12:46     45: 0x55bb6f2cef9c node::heap::CreateHeapSnapshotStream(v8::FunctionCallbackInfo<v8::Value> const&) [out/Debug/node]
09:12:46     46: 0x55bb6f67178e v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo) [out/Debug/node]
09:12:46     47: 0x55bb6f674119  [out/Debug/node]
09:12:46     48: 0x55bb6f6754ff  [out/Debug/node]
09:12:46     49: 0x55bb6f676033 v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [out/Debug/node]
09:12:46     50: 0x55bb703e0420  [out/Debug/node]

ref: https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_debug_x64/18285/console
@gireeshpunathil
Copy link
Member Author

same assertion failure for parallel/test-http2-server-close-callback and parallel/test-http2-server-sessionerror

@gireeshpunathil
Copy link
Member Author

cc @nodejs/http2 @nodejs/v8

@addaleax addaleax added async_wrap invalid Issues and PRs that are invalid. labels Feb 26, 2020
@addaleax
Copy link
Member

Not a flaky test, this is a genuine failure from #31745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid Issues and PRs that are invalid.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@addaleax @gireeshpunathil