Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow code caches to be created for modules #31233

Closed
justinfagnani opened this issue Jan 6, 2020 · 1 comment · Fixed by #31278
Closed

Allow code caches to be created for modules #31233

justinfagnani opened this issue Jan 6, 2020 · 1 comment · Fixed by #31278
Assignees
Labels
vm Issues and PRs related to the vm subsystem.

Comments

@justinfagnani
Copy link

Is your feature request related to a problem? Please describe.

vm.Module doesn't have createCachedData() like vm.Script does, nor an option to pass a code cache to its constructor.

Describe the solution you'd like

For applications where module graph startup time is critical, and we're instantiating the same module graph repeatedly, it would be very helpful to have some analogs to createCachedData(). In my cases the module graph is identical, so even the result of linking will be the same.

Describe alternatives you've considered

Currently there are none.

@devsnek devsnek self-assigned this Jan 6, 2020
@devsnek
Copy link
Member

devsnek commented Jan 7, 2020

I feel like I looked into this before and hit some issues. I'll take another look this week.

@devsnek devsnek added the vm Issues and PRs related to the vm subsystem. label Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vm Issues and PRs related to the vm subsystem.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants