Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs-capacitor module broken by backwards compat code in fs.ReadStream.open #30110

Closed
targos opened this issue Oct 25, 2019 · 6 comments
Closed

Comments

@targos
Copy link
Member

targos commented Oct 25, 2019

#29061 broke the fs-capacitor module (used by graphql-upload to handle file uploads).
I don't know if that module could be refactored to fix this but currently it overloads the open method (and still calls it internally) so this results in an infinite recursion: https://github.com/mike-marcacci/fs-capacitor/blob/51ce05dfa8bfa7d915447d700d36e422480c43e0/src/index.mjs#L70-L79

Originally posted by @targos in #29061

@ronag @mcollina

@ronag
Copy link
Member

ronag commented Oct 25, 2019

I'll look into whether we can do the deprecation in manner that does not break this.

@ronag
Copy link
Member

ronag commented Oct 25, 2019

@targos: Though we should probably also look into refactoring the module since deprecation means that it should be removed eventually.

@ronag
Copy link
Member

ronag commented Oct 25, 2019

Would be a lot easier to refactor and fix post #29656

@ronag
Copy link
Member

ronag commented Oct 25, 2019

Opened mike-marcacci/fs-capacitor#14 to help the module fix streams usage.

@ronag
Copy link
Member

ronag commented Nov 1, 2019

@targos: My PR which fixes this in fs-capacitor has been merged and a new release should be available soonish.

Do we still want to do something in Node or can we close this?

@targos
Copy link
Member Author

targos commented Nov 2, 2019

@ronag Thanks for fixing the module! I think we're good.

@targos targos closed this as completed Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants