IncomingMessage will emit end after aborted

[ronag]

I encountered this while working on my nodejs based proxy server and retries of GET requests.

It turns out that when an upstream server dies the nodejs requests in the proxy will emit the following events:

aborted
end
close

The end event I find a little strange to receive after a connection has been forcefully aborted.

Can someone confirm whether this is intentional or not?

[ronag]

It would be much easier if it didn't end after aborted. That way I can choose the behavior. As it is now I can't use pipe or pipeline if I don't want this behavior.

But I also can't not use pipe since the following commit has not been merged into LTS (20c3ac2), i.e. none pipe based streaming is broken...

I'm a little stuck at the moment...

[ronag]

OSX, Node 10.13.0

const http = require('http')

http.createServer(function (req, res) {
  res.write(Buffer.alloc(32))
  setTimeout(() => (
    res.destroy()
  ), 1000)
}).listen(0, function () {
  http.request({
    port: this.address().port,
    method: 'GET',
    path: '/'
  }).on('response', res => res
    .on('data', () => {})
    .on('aborted', () => console.log('aborted'))
    .on('end', () => console.log('end'))
    .on('close', () => console.log('close'))
  ).end()
})

Will print

aborted
end
close

[lpinca]

Issue title is misleading, ClientRequest extends OutgoingMessage and does not emit 'end'. It should be IncomingMessage.

[Trott]

Landed in 5f80df8

[Trott]

Whoops! Wrong window! But now that that landed, I think this can be closed?