flaky: parallel/test-async-hooks-http-parser-destroy.js #26610
Labels
arm
Issues and PRs related to the ARM platform.
async_hooks
Issues and PRs related to the async hooks subsystem.
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
Comments
refack
added
the
flaky-test
|
A second failure with that test on test-requireio_svincent-debian9-armv7l_pi2-3: https://ci.nodejs.org/job/node-test-binary-arm/6797/RUN_SUBSET=1,label=pi2-docker/console 00:18:01 not ok 36 parallel/test-async-hooks-http-parser-destroy
00:18:01 ---
00:18:01 duration_ms: 10.739
00:18:01 severity: fail
00:18:01 exitcode: 1
00:18:01 stack: |-
00:18:01 assert.js:340
00:18:01 throw err;
00:18:01 ^
00:18:01
00:18:01 AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
00:18:01
00:18:01 assert.ok(destroyedIds.indexOf(createdAsyncId) >= 0)
00:18:01
00:18:01 at createdIds.forEach (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:43:16)
00:18:01 at Array.forEach (<anonymous>)
00:18:01 at Timeout.setTimeout [as _onTimeout] (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:42:18)
00:18:01 at listOnTimeout (timers.js:335:15)
00:18:01 at processTimers (timers.js:279:5)
00:18:01 ... |
|
A third: https://ci.nodejs.org/job/node-test-binary-arm/6792/RUN_SUBSET=1,label=pi2-docker/console test-requireio_mcollina-debian9-armv7l_pi2-1 17:20:28 not ok 36 parallel/test-async-hooks-http-parser-destroy
17:20:28 ---
17:20:28 duration_ms: 11.536
17:20:28 severity: fail
17:20:28 exitcode: 1
17:20:28 stack: |-
17:20:28 assert.js:340
17:20:28 throw err;
17:20:28 ^
17:20:28
17:20:28 AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
17:20:28
17:20:28 assert.ok(destroyedIds.indexOf(createdAsyncId) >= 0)
17:20:28
17:20:28 at createdIds.forEach (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:43:16)
17:20:28 at Array.forEach (<anonymous>)
17:20:28 at Timeout.setTimeout [as _onTimeout] (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:42:18)
17:20:28 at listOnTimeout (timers.js:335:15)
17:20:28 at processTimers (timers.js:279:5)
17:20:28 ... |
|
Fourth: https://ci.nodejs.org/job/node-test-binary-arm/6946/RUN_SUBSET=1,label=pi2-docker/console test-requireio_mcollina-debian9-armv7l_pi2-1 00:12:34 ok 34 parallel/test-child-process-exec-stdout-stderr-data-string
00:12:34 ---
00:12:34 duration_ms: 2.536
00:12:34 ...
00:12:36 not ok 35 parallel/test-async-hooks-http-parser-destroy
00:12:36 ---
00:12:36 duration_ms: 10.285
00:12:36 severity: fail
00:12:37 exitcode: 1
00:12:37 stack: |-
00:12:37 assert.js:340
00:12:37 throw err;
00:12:37 ^
00:12:37
00:12:37 AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
00:12:37
00:12:37 assert.ok(destroyedIds.indexOf(createdAsyncId) >= 0)
00:12:37
00:12:37 at /home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:43:16
00:12:37 at Array.forEach (<anonymous>)
00:12:37 at Timeout._onTimeout (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:42:18)
00:12:37 at listOnTimeout (timers.js:335:15)
00:12:37 at processTimers (timers.js:279:5)
00:12:37 ...Fifth: https://ci.nodejs.org/job/node-test-binary-arm/6946/RUN_SUBSET=1,label=pi3-docker/console test-requireio_securogroup-debian9-arm64_pi3-2 00:12:14 not ok 41 parallel/test-async-hooks-http-parser-destroy
00:12:14 ---
00:12:14 duration_ms: 8.545
00:12:14 severity: fail
00:12:14 exitcode: 1
00:12:14 stack: |-
00:12:14 assert.js:340
00:12:14 throw err;
00:12:14 ^
00:12:14
00:12:14 AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
00:12:14
00:12:14 assert.ok(destroyedIds.indexOf(createdAsyncId) >= 0)
00:12:14
00:12:14 at /home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:43:16
00:12:14 at Array.forEach (<anonymous>)
00:12:14 at Timeout._onTimeout (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:42:18)
00:12:14 at listOnTimeout (timers.js:335:15)
00:12:14 at processTimers (timers.js:279:5)
00:12:14 ... |
|
Recent data points:
Example |
|
Looks like this only happens on the pis |
4 tasks
|
https://ci.nodejs.org/job/node-test-binary-arm/7110/RUN_SUBSET=3,label=pi2-docker/console test-requireio_svincent-debian9-armv7l_pi2-2 00:15:40 not ok 35 parallel/test-async-hooks-http-parser-destroy
00:15:40 ---
00:15:40 duration_ms: 10.990
00:15:40 severity: fail
00:15:40 exitcode: 1
00:15:40 stack: |-
00:15:40 assert.js:343
00:15:40 throw err;
00:15:40 ^
00:15:40
00:15:40 AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
00:15:40
00:15:40 assert.ok(destroyedIds.indexOf(createdAsyncId) >= 0)
00:15:40
00:15:40 at /home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:43:16
00:15:40 at Array.forEach (<anonymous>)
00:15:40 at Timeout._onTimeout (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:42:18)
00:15:40 at listOnTimeout (internal/timers.js:535:17)
00:15:40 at processTimers (internal/timers.js:479:7)
00:15:40 ... |
|
https://ci.nodejs.org/job/node-test-binary-arm/7250/RUN_SUBSET=3,label=pi1-docker/console test-requireio_bengl-debian9-armv6l_pi1p-2 00:19:48 not ok 24 parallel/test-async-hooks-http-parser-destroy
00:19:48 ---
00:19:48 duration_ms: 14.124
00:19:48 severity: fail
00:19:48 exitcode: 1
00:19:48 stack: |-
00:19:48 assert.js:343
00:19:48 throw err;
00:19:48 ^
00:19:48
00:19:48 AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
00:19:48
00:19:48 assert.ok(destroyedIds.indexOf(createdAsyncId) >= 0)
00:19:48
00:19:48 at /home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:43:16
00:19:48 at Array.forEach (<anonymous>)
00:19:48 at Timeout._onTimeout (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:42:18)
00:19:48 at listOnTimeout (internal/timers.js:535:17)
00:19:48 at processTimers (internal/timers.js:479:7)
00:19:48 ... |
|
The test takes a bit longer to run than most other tests in |
|
Yes, definitely room to dial it down a lot and still have it fail on the regression it is meant to test for. Experimenting a bit and will open a PR soon.... |
|
(Although I guess maybe not since that probably doesn't explain why this is failing on the Pi's? Maybe it will become obvious while refactoring...) |
|
Looks like the |
2 tasks
|
https://ci.nodejs.org/job/node-test-binary-arm/7440/RUN_SUBSET=2,label=pi2-docker/testReport/ test.parallel/test-async-hooks-http-parser-destroy
assert.js:343
throw err;
^
AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
assert.ok(destroyedIds.indexOf(createdAsyncId) >= 0)
at /home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:43:16
at Array.forEach (<anonymous>)
at Timeout._onTimeout (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:42:18)
at listOnTimeout (internal/timers.js:537:17)
at processTimers (internal/timers.js:481:7)Worker: https://ci.nodejs.org/computer/test-requireio_rvagg-debian9-armv7l_pi2-1/ |
|
https://ci.nodejs.org/job/node-test-binary-arm/7464/RUN_SUBSET=2,label=pi3-docker/console test-requireio_pivotalagency-debian9-arm64_pi3-2 00:07:12 not ok 38 parallel/test-async-hooks-http-parser-destroy
00:07:12 ---
00:07:12 duration_ms: 10.441
00:07:12 severity: fail
00:07:12 exitcode: 1
00:07:12 stack: |-
00:07:12 assert.js:343
00:07:12 throw err;
00:07:12 ^
00:07:12
00:07:12 AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
00:07:12
00:07:12 assert.ok(destroyedIds.indexOf(createdAsyncId) >= 0)
00:07:12
00:07:12 at /home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:43:16
00:07:12 at Array.forEach (<anonymous>)
00:07:12 at Timeout._onTimeout (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-async-hooks-http-parser-destroy.js:42:18)
00:07:12 at listOnTimeout (internal/timers.js:537:17)
00:07:12 at processTimers (internal/timers.js:481:7)
00:07:12 ... |
refack
added a commit
to refack/node
that referenced
this issue
Apr 11, 2019
PR-URL: nodejs#27193 Refs: nodejs#20750 Refs: nodejs#26610 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Trott
added a commit
to Trott/io.js
that referenced
this issue
Apr 19, 2019
Simplify test-async-hooks-http-parser-destroy and improve it's reporting
when failing. (Also makes it easier to run on older versions of Node.js
because it doesn't rely on internal test modules that won't work there.)
Before, failures looked like this (edited slightly to conform to our
commit message 72-char line length restriction):
The expression evaluated to a falsy value:
assert.ok(destroyedIds.indexOf(createdAsyncId) >= 0)
Now, you get a slightly better idea of what's up. (Is it missing one ID?
More than one? All of them?):
Input A expected to strictly deep-equal input B:
+ expected - actual ... Lines skipped
Set {
1009,
...
1025,
- 158,
- 159,
- 161,
- 162,
- 164,
- 165,
- 167,
- 168,
- 170,
...
+ 159,
+ 162,
+ 165,
+ 168,
+ 171,
+ 174,
+ 177,
+ 180,
+ 183,
This test still fails as expected on 10.14.1 and passees on 10.14.2
(where the regression it tests for was fixed). (You will need to comment
on the `require('../common');` line first but that's now the only change
you need to make this run in older versions.)
Refs: nodejs#26610
sam-github
added
the
async_hooks
|
I don't think the error above has shown up in a long time but the test did time out in CI on win2012r2/vs2019. |
There is code in the test to handle process.on('SIGTERM', () => {
// Catching SIGTERM and calling `process.exit(1)` so that the `exit` event
// is triggered and the assertions are checked. This can be useful for
// troubleshooting this test if it times out.
process.exit(1);
});Thoughts on what to do instead? I'd rather not sprinkle |
Trott
added a commit
to Trott/io.js
that referenced
this issue
Mar 6, 2021
This CI test failure hasn't been reported for some time. Closes: nodejs#26610
danielleadams
pushed a commit
that referenced
this issue
Mar 16, 2021
This CI test failure hasn't been reported for some time. Closes: #26610 PR-URL: #37636 Fixes: #26610 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
pushed a commit
that referenced
this issue
May 1, 2021
This CI test failure hasn't been reported for some time. Closes: #26610 PR-URL: #37636 Fixes: #26610 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Failed job
Worker: https://ci.nodejs.org/computer/test-requireio_mcollina-debian9-armv7l_pi2-1/
Test:
node/test/parallel/test-async-hooks-http-parser-destroy.js
Lines 42 to 43 in f2064df
The text was updated successfully, but these errors were encountered: