Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failing InspectorSocketServerTest.ServerCannotStart #25353

Closed
prabodh1194 opened this issue Jan 5, 2019 · 7 comments
Closed

Test failing InspectorSocketServerTest.ServerCannotStart #25353

prabodh1194 opened this issue Jan 5, 2019 · 7 comments
Labels
help wanted Issues that need assistance from volunteers or PRs that need help to proceed. inspector Issues and PRs related to the V8 inspector protocol windows Issues and PRs related to the Windows platform.

Comments

@prabodh1194
Copy link

prabodh1194 commented Jan 5, 2019

  • Version: v11.6.0
  • Platform: Linux LAPTOP-QI9H38HR 4.4.0-18309-Microsoft import from, export class #1000-Microsoft Thu Dec 20 12:56:00 PST 2018 x86_64 x86_64 x86_64 GNU/Linux
  • Subsystem: test/cctest

Hi,

I'm trying to setup node development environment in "Window's Ubuntu subsystem". Make completes successfully. However, there is one failing test:

[ RUN ] InspectorSocketServerTest.ServerCannotStart
../test/cctest/test_inspector_socket_server.cc:488: Failure
Value of: server2->Start()
Actual: true
Expected: false
[--I] signal 0x26539a8
[-AI] async 0x26537f0
[R--] tcp 0x44d1c30
[R--] tcp 0x44d1e40
../test/cctest/test_inspector_socket_server.cc:82: Failure
Value of: err
Actual: -16
Expected: 0
[ FAILED ] InspectorSocketServerTest.ServerCannotStart (0 ms)

I've run following set of steps:

./configure
make -j4
make -j4 test-only

@prabodh1194
Copy link
Author

prabodh1194 commented Jan 5, 2019

I modified following line to pass stderr and set has_targets as true.
ServerHolder(bool has_targets, uv_loop_t* loop, int port) : ServerHolder(has_targets, loop, HOST, port, stderr) { }

Received following output. Looks like 2 servers did get started. On same ports as well.

[ RUN ] InspectorSocketServerTest.ServerCannotStart
Debugger listening on ws://127.0.0.1:53088/main-target
For help, see: https://nodejs.org/en/docs/inspector
Debugger listening on ws://127.0.0.1:53088/main-target
For help, see: https://nodejs.org/en/docs/inspector

../test/cctest/test_inspector_socket_server.cc:489: Failure
Value of: server2->Start()
Actual: true
Expected: false
[--I] signal 0x26539a8
[-AI] async 0x26537f0
[R--] tcp 0x2c5fb50
[R--] tcp 0x2c5fc60
resource busy or locked
../test/cctest/test_inspector_socket_server.cc:83: Failure
Value of: err
Actual: -16
Expected: 0
[ FAILED ] InspectorSocketServerTest.ServerCannotStart (0 ms)

@Trott Trott added the windows Issues and PRs related to the Windows platform. label Jan 5, 2019
@iamlockon
Copy link

Ran into the same failure when I ran make test-only:

Version: v14.0.0-pre
Platform: Linux DESKTOP 4.4.0-17763-Microsoft #864-Microsoft x86_64 x86_64 x86_64 GNU/Linux
Subsystem: test/cctest

I followed @prabodh1194 's edits and had following Test output:

[ RUN      ] InspectorSocketServerTest.ServerCannotStart
For help, see: https://nodejs.org/en/docs/inspector
Debugger listening on ws://127.0.0.1:61548/main-target
For help, see: https://nodejs.org/en/docs/inspector
../test/cctest/test_inspector_socket_server.cc:492: Failure
Value of: server2->Start()
  Actual: true
Expected: false
[--I] signal   0x7f4d7225f728
[-AI] async    0x7f4d7225f570
[R--] tcp      0x7fffc0bea000
[R--] tcp      0x7fffc0bbd2b0
../test/cctest/test_inspector_socket_server.cc:85: Failure
Expected equality of these values:
  0
  err
    Which is: -16
[  FAILED  ] InspectorSocketServerTest.ServerCannotStart (2 ms)

Cannot figure out why at the moment.

@jasnell jasnell added help wanted Issues that need assistance from volunteers or PRs that need help to proceed. inspector Issues and PRs related to the V8 inspector protocol labels Jun 26, 2020
@jasnell
Copy link
Member

jasnell commented Jun 26, 2020

@nodejs/inspector

@Xstoudi
Copy link
Contributor

Xstoudi commented Oct 22, 2022

Also happening:

on head
Linux DESKTOP-IDCFP6T 4.4.0-19041-Microsoft #1237-Microsoft Sat Sep 11 14:32:00 PST 2021 x86_64 x86_64 x86_64 GNU/Linux
Subsystem : test/cctest

@Xstoudi
Copy link
Contributor

Xstoudi commented Oct 22, 2022

If I edit the failing test to make it virtually pass, I have those tests that also fail with the same -16 error code:

[ RUN      ] InspectorSocketServerTest.InspectorSessions
../../test/cctest/test_inspector_socket_server.cc:85: Failure
Expected equality of these values:
  -16
  err
    Which is: 0
[  FAILED  ] InspectorSocketServerTest.InspectorSessions (2 ms)
[ RUN      ] InspectorSocketServerTest.ServerDoesNothing
../../test/cctest/test_inspector_socket_server.cc:85: Failure
Expected equality of these values:
  -16
  err
    Which is: 0
[  FAILED  ] InspectorSocketServerTest.ServerDoesNothing (0 ms)
[ RUN      ] InspectorSocketServerTest.ServerWithoutTargets
../../test/cctest/test_inspector_socket_server.cc:85: Failure
Expected equality of these values:
  -16
  err
    Which is: 0
[  FAILED  ] InspectorSocketServerTest.ServerWithoutTargets (1 ms)
[ RUN      ] InspectorSocketServerTest.ServerCannotStart
../../test/cctest/test_inspector_socket_server.cc:495: Failure
Value of: server2->Start()
  Actual: true
Expected: false
[  FAILED  ] InspectorSocketServerTest.ServerCannotStart (1 ms)
[ RUN      ] InspectorSocketServerTest.StoppingServerDoesNotKillConnections
../../test/cctest/test_inspector_socket_server.cc:85: Failure
Expected equality of these values:
  -16
  err
    Which is: 0
[  FAILED  ] InspectorSocketServerTest.StoppingServerDoesNotKillConnections (1 ms)
[ RUN      ] InspectorSocketServerTest.ClosingConnectionReportsDone
../../test/cctest/test_inspector_socket_server.cc:85: Failure
Expected equality of these values:
  -16
  err
    Which is: 0
[  FAILED  ] InspectorSocketServerTest.ClosingConnectionReportsDone (1 ms)
[ RUN      ] InspectorSocketServerTest.ClosingSocketReportsDone
../../test/cctest/test_inspector_socket_server.cc:85: Failure
Expected equality of these values:
  -16
  err
    Which is: 0
[  FAILED  ] InspectorSocketServerTest.ClosingSocketReportsDone (2 ms)
[ RUN      ] InspectorSocketServerTest.TerminatingSessionReportsDone
../../test/cctest/test_inspector_socket_server.cc:85: Failure
Expected equality of these values:
  -16
  err
    Which is: 0
[  FAILED  ] InspectorSocketServerTest.TerminatingSessionReportsDone (1 ms)
[ RUN      ] InspectorSocketServerTest.FailsToBindToNodejsHost
../../test/cctest/test_inspector_socket_server.cc:85: Failure
Expected equality of these values:
  -16
  err
    Which is: 0
[  FAILED  ] InspectorSocketServerTest.FailsToBindToNodejsHost (13 ms)
[ RUN      ] InspectorSocketServerTest.BindsToIpV6
../../test/cctest/test_inspector_socket_server.cc:85: Failure
Expected equality of these values:
  -16
  err
    Which is: 0
[  FAILED  ] InspectorSocketServerTest.BindsToIpV6 (1 ms)
[----------] 10 tests from InspectorSocketServerTest (30 ms total)

[----------] Global test environment tear-down
[==========] 143 tests from 22 test suites ran. (5615 ms total)
[  PASSED  ] 133 tests.
[  FAILED  ] 10 tests, listed below:
[  FAILED  ] InspectorSocketServerTest.InspectorSessions
[  FAILED  ] InspectorSocketServerTest.ServerDoesNothing
[  FAILED  ] InspectorSocketServerTest.ServerWithoutTargets
[  FAILED  ] InspectorSocketServerTest.ServerCannotStart
[  FAILED  ] InspectorSocketServerTest.StoppingServerDoesNotKillConnections
[  FAILED  ] InspectorSocketServerTest.ClosingConnectionReportsDone
[  FAILED  ] InspectorSocketServerTest.ClosingSocketReportsDone
[  FAILED  ] InspectorSocketServerTest.TerminatingSessionReportsDone
[  FAILED  ] InspectorSocketServerTest.FailsToBindToNodejsHost
[  FAILED  ] InspectorSocketServerTest.BindsToIpV6

@huseyinacacak-janea
Copy link
Contributor

Hi @prabodh1194 I wanted to look into this issue but wasn't able to reproduce it (I tried Node 18.20.2, 20.12.2, and 22.0.0). Do you think this can be closed now?

@prabodh1194
Copy link
Author

I'm not impacted by these issues anymore go sure. So it's a go ahead for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues that need assistance from volunteers or PRs that need help to proceed. inspector Issues and PRs related to the V8 inspector protocol windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

7 participants