Node crashes when writing data on HTTP2 stream that meanwhile terminates

[hermanbanken]

• Version: v8.12.0
• Platform: OSX, Darwin mymac.local 17.7.0 Darwin Kernel Version 17.7.0: Thu Jun 21 22:53:14 PDT 2018; root:xnu-4570.71.2~1/RELEASE_X86_64 x86_64
• Subsystem: http2

When performing something along the lines of:

const http2Session = ...;
const outHeaders = { ... };
const req = http2Session.request({ ...outHeaders, [HTTP2_HEADER_PATH]: path });
const body: Buffer[] = [];
let headers: IncomingHttpHeaders = {};
req
      .on("response", (hs) => headers = hs)
      .on("data", (chunk) => body.push(chunk))
      .on("error", (error) => reject(error))
      .on("end", () => resolve({
        headers,
        status: parseInt(headers[HTTP2_HEADER_STATUS], 10),
        body: Buffer.concat(body),
      }));
req.end(Buffer.from("MYDATA"));

and the NGINX server becomes unavailable (shutsdown, GOAWAY, sessions close) sometimes we get the following error:

node[25931]: ../src/tls_wrap.cc:604:virtual int node::TLSWrap::DoWrite(node::WriteWrap *, uv_buf_t *, size_t, uv_stream_t *): Assertion `(ssl_) != (nullptr)' failed.
 1: node::Abort() [/Users/hbanken/.nvm/versions/node/v8.12.0/bin/node]
 2: node::(anonymous namespace)::DomainEnter(node::Environment*, v8::Local<v8::Object>) [/Users/hbanken/.nvm/versions/node/v8.12.0/bin/node]
 3: node::TLSWrap::DoWrite(node::WriteWrap*, uv_buf_t*, unsigned long, uv_stream_s*) [/Users/hbanken/.nvm/versions/node/v8.12.0/bin/node]
 4: node::http2::Http2Session::SendPendingData() [/Users/hbanken/.nvm/versions/node/v8.12.0/bin/node]
 5: node::http2::Http2Stream::RstStream(v8::FunctionCallbackInfo<v8::Value> const&) [/Users/hbanken/.nvm/versions/node/v8.12.0/bin/node]
 6: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&)) [/Users/hbanken/.nvm/versions/node/v8.12.0/bin/node]
 7: v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments) [/Users/hbanken/.nvm/versions/node/v8.12.0/bin/node]
 8: v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) [/Users/hbanken/.nvm/versions/node/v8.12.0/bin/node]
 9: 0x3671961042fd
10: 0x3671961bd1d6

Expected behavior:

Native error is caught and converted in something NodeJS can handle instead of crashing the whole process.

[hermanbanken]

Seems to be resolved by 0c25cdf #18987 and error might be a duplicate of #18973.

[hermanbanken]

Also #19002 seems to be related.

[hermanbanken]

Question remaining: can we backport to 8.12 or don't we because it is experimental in 8.12?

[richardlau]

Quite a few http2 commits have been backported for the proposed 8.13.0: #23974

[hermanbanken]

But not yet #19002 or #18973, right?

[richardlau]

I believe #19002 was included in v8.11.2 via c976cb5be5 as part of #20456.

[hermanbanken]

That is unfortunate, as it has npm 5.6: we need at least 8.12 (because npm 5.7 with npm ci) and can't switch to Node 10.13 as there is an issue related to OpenSSL (1.1.0?) causing a ssl3_GET_RECORD:wrong version number on the client.

[richardlau]

Not sure I follow you, 8.12 should contain all of the commits in 8.11.2 (unless something was reverted, but I don't believe that was the case).

[hermanbanken]

I’m having these issues with 8.12, so no, this is not fixed in 8.12. 8.11.2 could be released later than 8.12, right? Theoretically. As .2 is a patch. Other explanation is that the linked fix/fixes do not solve this issue.

[sam-github]

We could do an 8.11.2 by the rules of semver... but we don't do that. Since 8.12 has no incompatible changes from 8.11.2, we would ask anyone having a problem with 8.11.x to upgrade to 8.12.x (or later).

[Trott]

@nodejs/http2

[addaleax]

I’m closing this as v8.x is no longer supported … sorry if that wasn’t the outcome everyone was hoping for, but there aren’t going to be any more v8.x releases at this point.