Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: cherry-pick aac2f8c from upstream V8 #23638

Closed
demurgos opened this issue Oct 13, 2018 · 2 comments
Closed

deps: cherry-pick aac2f8c from upstream V8 #23638

demurgos opened this issue Oct 13, 2018 · 2 comments

Comments

@demurgos
Copy link
Contributor

demurgos commented Oct 13, 2018

  • Version: 10.12.0
  • Platform: Linux 64-bit (affects all platforms)
  • Subsystem: V8

Hi,
The V8 profiler had a bug when emitting coverage reports: it produced invalid counts. This bug is now fixed in upstream V8. In order to support V8 coverage reports, this bug should be also patched in the V8 version bundled with Node. This patch is required to safely merge reports produced by different processes (V8 sessions).

Could one of the maintainers cherry pick this commit?

@demurgos
Copy link
Contributor Author

demurgos commented Oct 17, 2018

This commit is currently on the branch canary-base. How likely is it that it will be part of Node 10.x? Having it on 10.x (instead of 11.x) would allow faster adoption of V8-based coverages.

@demurgos
Copy link
Contributor Author

Closed by 124d916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant