Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky addons-napi/test_threadsafe_function/test #23621

Closed
Trott opened this issue Oct 12, 2018 · 13 comments
Closed

Investigate flaky addons-napi/test_threadsafe_function/test #23621

Trott opened this issue Oct 12, 2018 · 13 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. node-api Issues and PRs related to the Node-API. windows Issues and PRs related to the Windows platform.

Comments

@Trott
Copy link
Member

Trott commented Oct 12, 2018

https://ci.nodejs.org/job/node-test-binary-windows/20671/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=1/console

11:33:39 not ok 551 addons-napi/test_threadsafe_function/test
11:33:39   ---
11:33:39   duration_ms: 5.819
11:33:39   severity: fail
11:33:39   exitcode: 134
11:33:39   stack: |-
11:33:39     FATAL ERROR: data_source_thread queue was never full
11:33:39      1: 00007FF66985BCE5 
11:33:39      2: 00007FF669834F56 
11:33:39      3: 00007FF669835940 
11:33:39      4: 00007FF669835959 
11:33:39      5: 00007FF66982843D 
11:33:39      6: 00007FFC92A711EE 
11:33:39      7: 00007FF669894884 
11:33:39      8: 00007FF66A33D660 
11:33:39      9: 00007FFC983B8364 
11:33:39     10: 00007FFC9894E851 
11:33:39   ...
@Trott Trott added flaky-test Issues and PRs related to the tests with unstable failures on the CI. node-api Issues and PRs related to the Node-API. labels Oct 12, 2018
@addaleax
Copy link
Member

@gabrielschulhof

@Trott
Copy link
Member Author

Trott commented Oct 26, 2018

https://ci.nodejs.org/job/node-test-binary-windows/21052/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=1/console on test-azure_msft-win2016-x64-2

00:57:07 not ok 555 addons-napi/test_threadsafe_function/test
00:57:07   ---
00:57:07   duration_ms: 6.378
00:57:07   severity: fail
00:57:07   exitcode: 134
00:57:07   stack: |-
00:57:07     FATAL ERROR: data_source_thread queue was never full
00:57:07      1: 00007FF749A6F6D5 
00:57:07      2: 00007FF749A47816 
00:57:07      3: 00007FF749A48200 
00:57:07      4: 00007FF749A48219 
00:57:07      5: 00007FF749A3ADCD 
00:57:07      6: 00007FFDA11F11EE 
00:57:07      7: 00007FF749AA8B54 
00:57:07      8: 00007FF74A566A70 
00:57:07      9: 00007FFDA8B58364 
00:57:07     10: 00007FFDAB57E851 
00:57:07   ...

@Trott
Copy link
Member Author

Trott commented Oct 26, 2018

@nodejs/n-api

@Trott
Copy link
Member Author

Trott commented Nov 1, 2018

https://ci.nodejs.org/job/node-test-binary-windows/21174/COMPILED_BY=vs2017-x86,RUNNER=win2012r2,RUN_SUBSET=1/console on test-azure_msft-win2012r2-x64-2

00:56:39 not ok 556 addons-napi/test_threadsafe_function/test
00:56:39   ---
00:56:39   duration_ms: 2.845
00:56:39   severity: fail
00:56:39   exitcode: 134
00:56:39   stack: |-
00:56:39     FATAL ERROR: data_source_thread queue was never full
00:56:39      1: 009C0B2E node::MakeCallback+3822
00:56:39      2: 7347141C data_source_thread+396 [c:\workspace\node-test-binary-windows\test\addons-napi\test_threadsafe_function\binding.c]:L104

@Trott Trott added the windows Issues and PRs related to the Windows platform. label Nov 1, 2018
@Trott
Copy link
Member Author

Trott commented Nov 1, 2018

@nodejs/platform-windows

@Trott
Copy link
Member Author

Trott commented Nov 2, 2018

https://ci.nodejs.org/job/node-test-binary-windows/21193/COMPILED_BY=vs2017-x86,RUNNER=win2012r2,RUN_SUBSET=1/console on test-azure_msft-win2012r2-x64-2

15:38:11 not ok 556 addons-napi/test_threadsafe_function/test
15:38:11   ---
15:38:11   duration_ms: 2.898
15:38:11   severity: fail
15:38:11   exitcode: 134
15:38:11   stack: |-
15:38:11     FATAL ERROR: data_source_thread queue was never full
15:38:11      1: 00A30B2E node::MakeCallback+3822
15:38:11      2: 7347141C data_source_thread+396 [c:\workspace\node-test-binary-windows\test\addons-napi\test_threadsafe_function\binding.c]:L104
15:38:11   ...

@Trott
Copy link
Member Author

Trott commented Nov 2, 2018

@nodejs/build This seems to perhaps be Azure-only failure?

@Trott
Copy link
Member Author

Trott commented Nov 28, 2018

https://ci.nodejs.org/job/node-test-binary-windows/21995/COMPILED_BY=vs2017-x86,RUNNER=win2012r2,RUN_SUBSET=1/console on test-azure_msft-win2012r2-x64-2:

19:55:05 not ok 555 addons-napi/test_threadsafe_function/test
19:55:05   ---
19:55:05   duration_ms: 2.927
19:55:05   severity: fail
19:55:05   exitcode: 134
19:55:05   stack: |-
19:55:05     FATAL ERROR: data_source_thread queue was never full
19:55:05      1: 00A873FE v8::internal::OptimizedCompilationInfo::bailout_reason+62590
19:55:05      2: 74CE141C data_source_thread+396 [c:\workspace\node-test-binary-windows\test\addons-napi\test_threadsafe_function\binding.c]:L104
19:55:05   ...

@Trott
Copy link
Member Author

Trott commented Nov 28, 2018

@nodejs/n-api

This was referenced Nov 28, 2018
Closed
Merged
gireeshpunathil added a commit to gireeshpunathil/node that referenced this issue Dec 1, 2018
@gireeshpunathil
test: mark test_threadsafe_function/test as flaky
2b1dd6c 
The test fails consistently on windows-fanned with vs2017.
mark it as flaky while the issue is being progressed, and
to keep CI green / amber.

Ref: nodejs#23621
PR-URL: nodejs#24714
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@richardlau richardlau mentioned this issue Dec 5, 2018
Closed
2 tasks
BridgeAR pushed a commit that referenced this issue Dec 5, 2018
@gireeshpunathil @BridgeAR
test: mark test_threadsafe_function/test as flaky
10c2773 
The test fails consistently on windows-fanned with vs2017.
mark it as flaky while the issue is being progressed, and
to keep CI green / amber.

Ref: #23621
PR-URL: #24714
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this issue Dec 28, 2018
@gireeshpunathil
test: mark test_threadsafe_function/test as flaky
e0e1ac2 
The test fails consistently on windows-fanned with vs2017.
mark it as flaky while the issue is being progressed, and
to keep CI green / amber.

Ref: nodejs#23621
PR-URL: nodejs#24714
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
refack pushed a commit to refack/node that referenced this issue Jan 14, 2019
@gireeshpunathil @refack
test: mark test_threadsafe_function/test as flaky
3dc2aaa 
The test fails consistently on windows-fanned with vs2017.
mark it as flaky while the issue is being progressed, and
to keep CI green / amber.

Ref: nodejs#23621
PR-URL: nodejs#24714
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this issue Jan 18, 2019
@gireeshpunathil @MylesBorins
test: mark test_threadsafe_function/test as flaky
b44bd88 
The test fails consistently on windows-fanned with vs2017.
mark it as flaky while the issue is being progressed, and
to keep CI green / amber.

Ref: #23621
Backport-PR-URL: #25002
PR-URL: #24714
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this issue Feb 12, 2019
@gireeshpunathil @BethGriggs
test: mark test_threadsafe_function/test as flaky
a7c72d7 
The test fails consistently on windows-fanned with vs2017.
mark it as flaky while the issue is being progressed, and
to keep CI green / amber.

Ref: #23621
PR-URL: #24714
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
rvagg pushed a commit that referenced this issue Feb 28, 2019
@gireeshpunathil @rvagg
test: mark test_threadsafe_function/test as flaky
36ace72 
The test fails consistently on windows-fanned with vs2017.
mark it as flaky while the issue is being progressed, and
to keep CI green / amber.

Ref: #23621
PR-URL: #24714
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
rvagg pushed a commit that referenced this issue Feb 28, 2019
@gireeshpunathil @rvagg
test: mark test_threadsafe_function/test as flaky
60db455 
The test fails consistently on windows-fanned with vs2017.
mark it as flaky while the issue is being progressed, and
to keep CI green / amber.

Ref: #23621
Backport-PR-URL: #25002
PR-URL: #24714
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott
Copy link
Member Author

Trott commented Mar 2, 2019

This doesn't seem to come up anymore. Is it possible some of the thread cleanup that happened fixed it as a positive side-effect?

Trott added a commit to Trott/io.js that referenced this issue Mar 2, 2019
@Trott
test: remove flaky designation for test_threadsafe_function
2404e41 
The test_threadsafe_function doesn't seem to be flaky anymore on
Windows. Optimistically removing the flaky designation in the relevant
status file.

Refs: nodejs#23621 (comment)
@Trott Trott mentioned this issue Mar 2, 2019
Closed
2 tasks
@Trott Trott closed this as completed Mar 4, 2019
Trott added a commit to Trott/io.js that referenced this issue Mar 4, 2019
@Trott
test: remove flaky designation for test_threadsafe_function
33880d7 
The test_threadsafe_function doesn't seem to be flaky anymore on
Windows. Optimistically removing the flaky designation in the relevant
status file.

Refs: nodejs#23621 (comment)

PR-URL: nodejs#26403
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this issue Mar 12, 2019
@Trott @BridgeAR
test: remove flaky designation for test_threadsafe_function
e1aa510 
The test_threadsafe_function doesn't seem to be flaky anymore on
Windows. Optimistically removing the flaky designation in the relevant
status file.

Refs: nodejs#23621 (comment)

PR-URL: nodejs#26403
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
BethGriggs pushed a commit that referenced this issue Apr 16, 2019
@Trott @BethGriggs
test: remove flaky designation for test_threadsafe_function
60880d7 
The test_threadsafe_function doesn't seem to be flaky anymore on
Windows. Optimistically removing the flaky designation in the relevant
status file.

Refs: #23621 (comment)

PR-URL: #26403
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@gireeshpunathil
Copy link
Member

seen again today:

19:24:06 not ok 112 node-api/test_threadsafe_function/test
19:24:06   ---
19:24:06   duration_ms: 8.4
19:24:06   severity: crashed
19:24:06   exitcode: -1073741819
19:24:06   stack: |-
19:24:06     FATAL ERROR: data_source_thread queue was never full
19:24:06   ...

ref: https://ci.nodejs.org/job/node-test-binary-windows-2/COMPILED_BY=vs2017-x86,RUNNER=win2012r2,RUN_SUBSET=addons/4470/consoleFull

@bzoz
Copy link
Contributor

bzoz commented Mar 26, 2020

I can't reproduce this on Win10 nor on Win2012. Does this happen anymore?

@Trott
Copy link
Member Author

Trott commented Mar 30, 2020

I can't reproduce this on Win10 nor on Win2012. Does this happen anymore?

I can't find any recent occurrences with ncu-ci walk so I think we can close this.

@Trott Trott closed this as completed Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. node-api Issues and PRs related to the Node-API. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: remove flaky designation for test_threadsafe_function Trott/io.js
4 participants
@Trott @addaleax @gireeshpunathil @bzoz