-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help with Windows builds #22535
Comments
cc @nodejs/platform-windows |
AFAICT is not a blocking error. Since it's an |
Ref: #22017 (comment) |
Yeah as the message indicate, this is just a warning. I noticed it while preparing #22017 but kept it because this file is also listed in Build.gn |
So the result here is that the warning is stopping the build process from continuing on Windows when it doesn't need to? Do we need to modify this batch file to continue if there are warnings? |
And thanks for the suggestions - this has had me stuck on Windows for months! |
Here's the full log if it helps -
The process then aborts at that point. Thanks again for help here. |
I wish I could help you more. I have a very similar output to yours, then just after the warning it says "Project files generated." and compilation starts. |
@guybedford could you try |
@bzoz here's the extended log:
Thanks for pointers. Any suggestions as to what toolchain I could try "uninstall and reinstall" would be appreciated... |
FWIW I have the latest version of the "Visual Studio Build Tools 2017" (selected "Visual C++ build tools" in the installer). |
Sure, let me try another installation. |
I've uninstalled everything to do with Visual Studio from my machine and reinstalled the Visual C++ build tools from the installer and still get the same issue. Any other suggestions welcome, but will close for now as an unsolvable mystery. |
|
I previously had Node.js builds working on both Ubuntu subsystem for Windows and through vcbuild.bat, but somehow over the last few months both of these builds have stopped working for me.
With vcbuild.bat it firstly doesn't find my Python install (C:\Python27, which is in PATH). I manually modified find_python.cmd to make sure it would find it, but then I get the following error:
Which I'm kind of clueless as to how to debug.
I've removed Node and re-cloned, reinstalled Visual Studio etc.
Is anyone else having issues building on Windows at all, or is this just me!?
Regardless, help would be appreciated. I'm fine with sticking with Mac workflows, but it would help to test certain things on Windows.
Look forward to being told I've missed something painfully obvious :)
The text was updated successfully, but these errors were encountered: