Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build break in src/tracing/agent.h #18361

Closed
kfarnung opened this issue Jan 25, 2018 · 2 comments
Closed

Build break in src/tracing/agent.h #18361

kfarnung opened this issue Jan 25, 2018 · 2 comments

Comments

@kfarnung
Copy link
Contributor

  • Version: master
  • Platform: windows, linux
  • Subsystem: tracing

It looks like #17489 and #18196 collided in master to break the build. The CurrentTimestampMicroseconds method was removed from the V8 type just as we took a dependency on it.

E:\GitHub\node\src\tracing/agent.h(15): error C3668: 'node::tracing::TracingController::CurrentTimestampMicroseconds': method with override specifier 'override' did not override any base class methods (compiling source file src\tracing\agent.cc) [E:\GitHub\node\node_lib.vcxproj]

/cc @ofrobots @targos @MylesBorins
@kfarnung
Copy link
Contributor Author

Looks like #18360 is open to resolve this.

@apapirovski
Copy link
Member

Fixed now that #18360 landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apapirovski @kfarnung