Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building v9.x-staging is broken #18048

Closed
jasnell opened this issue Jan 9, 2018 · 2 comments
Closed

Building v9.x-staging is broken #18048

jasnell opened this issue Jan 9, 2018 · 2 comments

Comments

@jasnell
Copy link
Member

jasnell commented Jan 9, 2018

@nodejs/backporting ... building v9.x-staging is currently broken.

../src/node_file.cc: In function ‘void node::FTruncate(const v8::FunctionCallbackInfo<v8::Value>&)’:
../src/node_file.cc:731:36: error: ‘IsInt64’ was not declared in this scope
       !IsInt64(len_v->NumberValue())) {
                                    ^
node.target.mk:202: recipe for target '/home/james/node/node/out/Release/obj.target/node/src/node_file.o' failed
make[1]: *** [/home/james/node/node/out/Release/obj.target/node/src/node_file.o] Error 1
make[1]: *** Waiting for unfinished jobs....
Makefile:89: recipe for target 'node' failed
make: *** [node] Error 2
james@ubuntu:~/node/node$m64 -fno-strict-aliasing -m64 -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++0x -MMD -MF /home/james/node/node/out/Release/.deps//home/james/node

Likely caused by a recent errant backport commit.

@jasnell
Copy link
Member Author

jasnell commented Jan 9, 2018

@MylesBorins
Copy link
Contributor

there were a couple different commits causing issues on staging, sorry about that. Was mass backporting to try and get stuff ready for a release.

The branch is now fixed 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants