-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI v8tests fails on master #16398
Comments
FWIW, I can't reproduce locally:
(For that matter, all the message tests pass.) |
Thanks for checking @bnoordhuis . I started another CI job on master. I'm confused because 1005 failed (with IMHO unrelated PR), 1007 passed, and 1008 failed again. If I read the test correctly, the test runner only compares refack: replace GitHub autolinks to CI manual links |
It goes to stderr. What you see is the test runner printing the captured output to stdout post facto, when the test is done:
|
Yes, was just a thought of what could maybe be different between local and CI. Did I mess up the parameters for #1009 and it's not the regular Node master? |
Nope, that's master alright. |
I'm doing preliminary biset: 1st candidate: 27e12e7 |
@refack Thanks for looking into this. Not sure if a bisect is useful - 1010 looks like a rerun of 1008, both with master and it's green again. Also, we can't reproduce it locally (and I don't see a difference between actual and expected output on the failing CI). |
1006 and 1007 are green as well - though they ran on the same or later master as 1005 (I'm pretty sure the 1005 PR does not cause the failure, also because we see the failure later on master without that PR merged in, I just landed it a few minutes ago and it's green in 1011)...seeing that it's green again, just close this? 😆 |
hmmm... with all this evidence it does look like a CI setup quirk. We can close this and I'll open an issue on the build repo |
sgtm |
Cross-ref: nodejs/build#936 |
When we ran node-test-commit-v8-linux on the CI for a V8 cherry-pick PR, we noticed that it's failing on master. Anybody want to bisect? Thanks 🙏 !
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1008/
It's the test in
v8/deps/test/message/console.js
. The test runner compares the output to the expected output inconsole.out
. But I don't see the difference.Actual output:
Expected output:
The text was updated successfully, but these errors were encountered: