Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error on performance.timerify(fn) example #15417

Closed
todojs opened this issue Sep 14, 2017 · 4 comments
Closed

Error on performance.timerify(fn) example #15417

todojs opened this issue Sep 14, 2017 · 4 comments
Labels
doc Issues and PRs related to the documentations.

Comments

@todojs
Copy link

todojs commented Sep 14, 2017

The example show

obs.observe({ entryTypes: 'function' });

Must be

obs.observe({ entryTypes: ['function'] });
@jasnell
Copy link
Member

jasnell commented Sep 14, 2017

Sigh. good catch :-)

@mscdex mscdex added the doc Issues and PRs related to the documentations. label Sep 14, 2017
@cjihrig
Copy link
Contributor

cjihrig commented Sep 14, 2017

A fix is in #15406.

@jasnell
Copy link
Member

jasnell commented Sep 14, 2017

Thanks @cjihrig ... it looked really familiar but couldn't recall off the top of my head.

@todojs todojs closed this as completed Sep 14, 2017
@todojs todojs reopened this Sep 14, 2017
@todojs
Copy link
Author

todojs commented Sep 14, 2017

Ok, it's fixes.

https://github.com/nodejs/node/pull/15406/files/383a4943ea958d110efd2e2577bac5dca9ca7708

(sorry the wrong reopen)

@todojs todojs closed this as completed Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mscdex @jasnell @cjihrig @todojs