Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header name is not added in the error message for the case of invalid characters in the header #14754

Closed
subeeshcbabu-zz opened this issue Aug 10, 2017 · 3 comments
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core. http Issues or PRs related to the http subsystem.

Comments

@subeeshcbabu-zz
Copy link

  • Version: 8.x, 6.x, 4.x (It could be all the versions)
  • Platform: all
  • Subsystem: http

Node http core module throws a TypeError - The header content contains invalid characters in the case of invalid characters present in any of the headers.

It would be awesome, if the name of the header is also gets added, as part of the error message here

Right now it is really difficlut to identify the root cause of the issue, from the error message.

The debuglog has the header name, however, enabling the http debuglog on a production like environment, generates lots of logs and it makes it really difficult to find the root cause of the issue from debuglogs.

@indutny
Copy link
Member

indutny commented Aug 10, 2017

cc @nodejs/http

Going to submit a PR in a bit.

@vsemozhetbyt vsemozhetbyt added errors Issues and PRs related to JavaScript errors originated in Node.js core. http Issues or PRs related to the http subsystem. labels Aug 10, 2017
@indutny
Copy link
Member

indutny commented Aug 11, 2017

PR: #14759

@maclover7
Copy link
Contributor

I think this was be solved via #14735 -- here's a sample of what the new error would look like. Please feel free to reopen if necessary :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core. http Issues or PRs related to the http subsystem.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants