Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.7.1 --shared-zlib fails #1434

Closed
Nibbler999 opened this issue Apr 15, 2015 · 2 comments
Closed

1.7.1 --shared-zlib fails #1434

Nibbler999 opened this issue Apr 15, 2015 · 2 comments
Labels
build Issues and PRs related to build files or the CI. confirmed-bug Issues with confirmed bugs. zlib Issues and PRs related to the zlib subsystem.

Comments

@Nibbler999
Copy link
Contributor

#1335 introduced a bug with option handling, it's using code like:

if b(options.shared_zlib) == True:

b returns 'true' or 'false' as a string and 'true' != True, so any builds using --shared-zlib currently fail with a linker error.
@mscdex mscdex added zlib Issues and PRs related to the zlib subsystem. build Issues and PRs related to build files or the CI. confirmed-bug Issues with confirmed bugs. labels Apr 15, 2015
@jbergstroem
Copy link
Member

My bad. See #1429 for a fix. Especially commit 867de71.

@Nibbler999 Nibbler999 mentioned this issue Apr 17, 2015
Closed
@Fishrock123 Fishrock123 mentioned this issue Apr 17, 2015
Closed
@Fishrock123
Copy link
Contributor

Fixed in 1.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. confirmed-bug Issues with confirmed bugs. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mscdex @jbergstroem @Nibbler999 @Fishrock123