Node 6.11.0 does not build for arm7

[davidchappelle]

• Version: v6.11.0
• Platform: Linux K000160 3.10.0-uc0 deps: update openssl to 1.0.1j #1 SMP Fri Nov 18 10:53:51 EST 2016 armv7l unknown

Here is the patch that I have to get it building.

diff --git a/deps/v8/build/toolchain.gypi b/deps/v8/build/toolchain.gypi
index faecf8e..17281cb 100644
--- a/deps/v8/build/toolchain.gypi
+++ b/deps/v8/build/toolchain.gypi
@@ -1011,8 +1011,8 @@
                     'cflags': [ '-m31' ],
                     'ldflags': [ '-m31' ]
                   },{
-                   'cflags': [ '-m32' ],
-                   'ldflags': [ '-m32' ]
+                   'cflags': [ '' ],
+                   'ldflags': [ '' ]
                   }],
                 ],
               }],

Basically removing the -m32 flag from toolchain.gypi. I am not a gyp ninja so I not sure what the correct patch is. Likely some additional conditional check to avoid this option if the target arch is arm.

[Trott]

@nodejs/build @nodejs/platform-arm

[MylesBorins]

Does v6.10.3 build fine?

This patch is landing directly on V8... is there a fix upstream?

/cc @nodejs/v8

[bnoordhuis]

Back-linking to #14112, #14112 (comment) in particular. Most likely a cross-compile toolchain issue, not a bug in V8's build scripts.

[MylesBorins]

@bnoordhuis can we close this then or is there something actionable?

[bnoordhuis]

Nothing actionable unless @davidchappelle came to a different conclusion. Pending follow-up, I'll close this for now.