Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test/parallel/test-fs-write-sync.js failed when node < 7.2.0 #13899

Closed
JacksonTian opened this issue Jun 24, 2017 · 3 comments
Closed

test: test/parallel/test-fs-write-sync.js failed when node < 7.2.0 #13899

JacksonTian opened this issue Jun 24, 2017 · 3 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.

Comments

@JacksonTian
Copy link
Contributor

  • Version: < 7.1.0
  • Platform: Darwin jacksontian-air 16.6.0 Darwin Kernel Version 16.6.0: Fri Apr 14 16:21:16 PDT 2017; root:xnu-3789.60.24~6/RELEASE_X86_64 x86_64
  • Subsystem: fs
# the v7.2.0 is OK.
$ ~/.tnvm/versions/node/v7.2.0/bin/node ~/git/nodejs/test/parallel/test-fs-write-sync.js 
# the versions before v7.2.0 is NOT OK.
$ ~/.tnvm/versions/node/v6.11.0/bin/node ~/git/nodejs/test/parallel/test-fs-write-sync.js 

assert.js:81
  throw new assert.AssertionError({
  ^
AssertionError: false == true
    at Object.<anonymous> (/Users/jacksontian/git/nodejs/test/parallel/test-fs-write-sync.js:57:10)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.runMain (module.js:604:10)
    at run (bootstrap_node.js:389:7)
    at startup (bootstrap_node.js:149:9)
    at bootstrap_node.js:504:3

I try to find out which commit fix it in v7.2.0, but failed.

The fixes should be back port to 4.x & 6.x.

@mscdex mscdex added fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests. labels Jun 24, 2017
@vsemozhetbyt
Copy link
Contributor

@JacksonTian #7856?

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Jun 25, 2017

It seems this is the backport for v6.x: #13179

@maclover7
Copy link
Contributor

Since the fix landed, going to close out this issue. If the tests starts to become flaky again, or if this needs to stay open, please reopen the issue :)

@maclover7 maclover7 added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Dec 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

5 participants
@mscdex @JacksonTian @maclover7 @vsemozhetbyt and others