Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: release-urlbase might be wrong set on current 8.1.1 release #13780

Closed
yorkie opened this issue Jun 19, 2017 · 1 comment
Closed

process: release-urlbase might be wrong set on current 8.1.1 release #13780

yorkie opened this issue Jun 19, 2017 · 1 comment
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs. process Issues and PRs related to the process subsystem.

Comments

@yorkie
Copy link
Contributor

yorkie commented Jun 19, 2017

  • Version: 8.1.1
  • Platform: macOS
  • Subsystem: process
$:node-v8.1.1-darwin-x64 yorkie$ bin/node -v
v8.1.1
$:node-v8.1.1-darwin-x64 yorkie$ bin/node
> process.release
{ name: 'node',
  sourceUrl: 'https://nodejs.org/download//v8.1.1/node-v8.1.1.tar.gz',
  headersUrl: 'https://nodejs.org/download//v8.1.1/node-v8.1.1-headers.tar.gz' }
>
(To exit, press ^C again or type .exit)

This release might be configured with --release-urlbase=https://nodejs.org/download//, v8.0.0 and v8.1.2 are working correctly, could we release again for v8.1.1 even though we didn't get any broken on gyp or other modules currently :)

/cc @nodejs/release

@yorkie yorkie added the process Issues and PRs related to the process subsystem. label Jun 19, 2017
@richardlau
Copy link
Member

8.1.2 was specifically made to fix this.

Closing as duplicate of #13667

@gibfahn gibfahn added the duplicate Issues and PRs that are duplicates of other issues or PRs. label Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs. process Issues and PRs related to the process subsystem.
Projects
None yet
Development

No branches or pull requests

3 participants