Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert.deepEqual treats RegExp literals equal to {} #1362

Closed
dickeylth opened this issue Apr 7, 2015 · 1 comment
Closed

assert.deepEqual treats RegExp literals equal to {} #1362

dickeylth opened this issue Apr 7, 2015 · 1 comment
Labels
assert Issues and PRs related to the assert subsystem.

Comments

@dickeylth
Copy link

Just as the title says,

~ ➤ n io use 1.6.4                                                                            
> assert.deepEqual(/a/, {})
undefined

expect AssertionError.
@dickeylth dickeylth changed the title assert.deepEqual treats RegExp objects equal to {} assert.deepEqual treats RegExp literals equal to {} Apr 7, 2015
@brendanashworth brendanashworth added the assert Issues and PRs related to the assert subsystem. label Apr 7, 2015
@dickeylth dickeylth mentioned this issue Apr 7, 2015
Open
@bnoordhuis
Copy link
Member

That was fixed by the introduction of assert.deepStrictEqual() in #639. People felt that modifying assert.deepEqual() would lead to too much fallout.

@snyk-bot snyk-bot mentioned this issue Apr 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bnoordhuis @dickeylth @brendanashworth