-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tracking issue: full VS2017 support #13052
Comments
/cc @nodejs/lts is it a goal for porting? (re: #12450 (comment) and following comments) |
I'm going to move forward with that.
I ran the tests with master when we started adding support and everything passed. Didn't try recently though. Re #12450 (comment), can you paste the errors you get here? |
I guess there's something wonky with symlinks on my machine. parallel\test-module-circular-symlinks
sequential\test-benchmark-http
addons/symlinked-module/test
|
Added VS2017 to Current status:
|
@joaocgreis 👍 |
What is the specific question that is on the LTS agenda for this issue? |
Do we want to start building v9.0.0 in VS2017 (or even move v8.x to VS2017 for LTS)? |
If it has no ABI or platform support implications then @nodejs/lts doesn't have an opinion. |
@joaocgreis what do you think about building /cc @nodejs/platform-windows |
Node v8 and v9 are far too close to move now, there are things to do that will take time.
To be careful, I'd wait a lot more before moving. But on the other hand we'll have to maintain the VS2015 infrastructure until it's needed, and sooner or later we'll start to have issues caused by VS2015. @refack are there other compelling reasons to move? So, my recommendation is that we move to VS2017 for v10. We can start the steps above after v9 is released to start releasing nightlies of v10 early, if no technical issues are found. Note that VS2015 is still in wide use, so we'll still have to support building node and native modules with it, as v10 is still too early to drop that. Ref issues where we dropped VS2013 and moved to VS2015 (as opposed to here, where we're just moving to VS2017, not dropping VS2015): #7484, #7989. cc @nodejs/build |
Sounds to me like all the steps we can take to prepare for using VS2017 can be started now without considering which version of Node it should land in. Once we're confident and have a few months of nightlies, we can switch for whichever is the next version of Node at the time. In fact if it's ABI compatible we can switch inside a release right? We'll have to test with all versions anyway. Agreed that Node 10.x sounds too early for dropping VS2015. |
We don't have guarantees of ABI compatibility. We should search for problems and hopefully find none, but we don't know for sure with all the exposed C++ ABI. So, it would be better to do it in a major version. |
Tracking issue
Goal: get
node
compiling with VS2017 and passing all testsGYP
(tools: bump gyp to eb296f6 #12450)breakdown of CI task by @joaocgreis:
The text was updated successfully, but these errors were encountered: