Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: sequential/test-fs-watch timeout on OS X #1273

Closed
silverwind opened this issue Mar 26, 2015 · 3 comments
Closed

fs: sequential/test-fs-watch timeout on OS X #1273

silverwind opened this issue Mar 26, 2015 · 3 comments
Labels
fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.

Comments

@silverwind
Copy link
Contributor

This fails every time here. I first put it off as a local issue, but now it comes up in some CI runs too:

=== release test-fs-watch ===
Path: sequential/test-fs-watch
Command: out/Release/iojs /Users/iojs/build/workspace/iojs+any-pr+multi/nodes/osx1010/test/sequential/test-fs-watch.js
--- TIMEOUT ---

https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/378/nodes=osx1010/

@silverwind silverwind added fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests. labels Mar 26, 2015
@silverwind
Copy link
Contributor Author

Correction: It fails around 80-90% of all runs on my machine (2013 MBA), investigating.

@silverwind
Copy link
Contributor Author

So this seems to be write timeout related. Changing the write timeouts from 10ms to 15ms seems to make the failures go away.

The last timeout change is here: c5ed96a

@bnoordhuis would you agree with increasing these timeouts to like 20ms to reduce test flakiness?

@silverwind
Copy link
Contributor Author

continued in #1275.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

1 participant