Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build node sources under visual studio 2013 #12070

Closed
benmouh opened this issue Mar 27, 2017 · 6 comments
Closed

Build node sources under visual studio 2013 #12070

benmouh opened this issue Mar 27, 2017 · 6 comments
Labels
build Issues and PRs related to build files or the CI. question Issues that look for answers. windows Issues and PRs related to the Windows platform.

Comments

@benmouh
Copy link

benmouh commented Mar 27, 2017

  • **Last master source **:
  • Windows:
  • ****:

Im trying to build the node sources just cloned on my local machine, then after runing the ./configure script , i open the visual project using visual studio 2013 then when i'm building i got some errors see the screenshot:
build_issue

I'm using windows as a plateform and visual studio 2013 as an IDE.

@Fishrock123 Fishrock123 added build Issues and PRs related to build files or the CI. question Issues that look for answers. windows Issues and PRs related to the Windows platform. labels Mar 27, 2017
@mscdex
Copy link
Contributor

mscdex commented Mar 27, 2017

The build requirements indicate you need VS 2015 or VC++ Build Tools 2015 or newer to build node.

@benmouh
Copy link
Author

benmouh commented Mar 27, 2017

@mscdex is there some code features in the node sources that prevent me to build on VS 2013, how about those people who used to work with 2013 version they cannot build node under windows so

@mscdex
Copy link
Contributor

mscdex commented Mar 27, 2017

See the original issue about dropping VS2013 support for more information.

@mscdex mscdex closed this as completed Mar 27, 2017
@gibfahn
Copy link
Member

gibfahn commented Mar 27, 2017

@benmouh It was mostly C++11 issues that caused the update.

You should be able to just install the Visual C++ Build Tools 2015, which are much smaller than VS 2015. Is there a reason you need VS 2013?

Note that you can still build native addons with VS 2013.

@benmouh
Copy link
Author

benmouh commented Mar 27, 2017

@gibfahn i'm just used to work with VS2013 for a while, then i think i have to jump into the VS2015, so good to know about native addons still support by VS2013.

Can you tell me about problem with C++ 11 when using 2013 i cannot figure out whats going wrong if you use 2013, i just read on comment that there was some issues with c++11 but still not clair anyway.

@gibfahn
Copy link
Member

gibfahn commented Mar 27, 2017

@benmouh I don't know that much about this, but you can see #8067 for some of the workarounds we had in our codebase as a result of having to support VS2013. I think the problem was that the number of these workarounds in Node and deps were becoming increasingly unmanageable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. question Issues that look for answers. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

4 participants