Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release proposal: v1.5.1 #1096

Closed
rvagg opened this issue Mar 8, 2015 · 16 comments
Closed

Release proposal: v1.5.1 #1096

rvagg opened this issue Mar 8, 2015 · 16 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@rvagg
Copy link
Member

rvagg commented Mar 8, 2015

This one is mainly aimed at trying to clear up anything outstanding for the leak mentioned in #1075. I'll wait for feedback there but we could ship this one out fairly quick if those involved think it's worth it.

  • [030a92347d] - benchmark: chunky http client benchmark variation (Rudi Cilibrasi) #228
  • [3b57819b58] - crypto: fix leak in SafeX509ExtPrint (Fedor Indutny) #1087
  • [f8c893dd39] - doc: fix confusion markdown in util.markdown (Yazhong Liu) #1097
  • [e763220f66] - doc: update clang version prerequisite (Brendan Ashworth) #1094
  • [0f7c8ebeea] - doc: replace article "an" with "a" in net docs (Evan Lucas) #1093
  • [cf565b5516] - fs: fix .write() not coercing non-string values (Jeremiah Senkpiel) #1102
  • [1a3ca8223e] - http_client: ensure empty socket on error (Fedor Indutny) #1103
  • [8670613d2d] - node_crypto_bio: adjust external memory size (Fedor Indutny) #1085
  • [528d8786ff] - src: fix memory leak in fs.writeSync error path (Ben Noordhuis) #1092
  • [648fc63cd1] - src: fix mismatched delete[] in src/node_file.cc (Ben Noordhuis) #1092
  • [9f7c9811e2] - src: add missing Context::Scope (Ben Noordhuis) #1084
  • [fe36076c78] - stream_base: WriteWrap::New/::Dispose (Fedor Indutny) #1090
  • [7f4c95e160] - tls: do not leak WriteWrap objects (Fedor Indutny) #1090
  • [4bd3620382] - url: remove redundant assignment in url.parse (Alex Kocharin) #1095
@jonathanong
Copy link
Contributor

👍

@cjihrig
Copy link
Contributor

cjihrig commented Mar 8, 2015

If the leak is confirmed to be fixed then I think this makes a lot of sense.

@rvagg
Copy link
Member Author

rvagg commented Mar 8, 2015

@GeoffreyPlitt
Copy link

+1

@Fishrock123
Copy link
Contributor

+1, once the fix is confirmed.

@rvagg
Copy link
Member Author

rvagg commented Mar 8, 2015

Working on getting this out today, RC is here: https://iojs.org/download/nightly/v1.5.1-nightly20150308f8c893dd39/

working on changelog header next

@rvagg
Copy link
Member Author

rvagg commented Mar 9, 2015

2015-03-09, Version 1.5.1, @rvagg

Notable changes

  • tls: The reported TLS memory leak has been at least partially resolved via various commits in this release. Current testing indicated that there may still be some leak problems. Track complete progress at #1075.
  • http: Fixed an error reported at joyent/node#9348 and npm/npm#7349. Pending data was not being fully read upon an 'error' event leading to an assertion failure on socket.destroy(). (Fedor Indutny) #1103

Known issues

  • Possible remaining TLS-related memory leak(s), details at #1075.
  • Windows still reports some minor test failures and we are continuing to address all of these as a priority. See #1005.
  • Surrogate pair in REPL can freeze terminal #690
  • Not possible to build io.js as a static library #686
  • process.send() is not synchronous as the docs suggest, a regression introduced in 1.0.2, see #760 and fix in #774
  • Calling dns.setServers() while a DNS query is in progress can cause the process to crash on a failed assertion #894

@rvagg
Copy link
Member Author

rvagg commented Mar 9, 2015

final test run (hopefully) https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/263/

@rvagg
Copy link
Member Author

rvagg commented Mar 9, 2015

Bailing on this for now. Still some TLS leakage being reported so we should sit on this for a bit.

@rvagg rvagg closed this as completed Mar 9, 2015
@Fishrock123
Copy link
Contributor

#1103 is closed, fedor suggested we do a release anyways.

@Fishrock123 Fishrock123 reopened this Mar 9, 2015
@rvagg
Copy link
Member Author

rvagg commented Mar 9, 2015

@rvagg
Copy link
Member Author

rvagg commented Mar 9, 2015

updated release notes above to say that the leak probably isn't fixed

@rvagg
Copy link
Member Author

rvagg commented Mar 9, 2015

put #1103 in notable changes

@rvagg
Copy link
Member Author

rvagg commented Mar 9, 2015

@rvagg
Copy link
Member Author

rvagg commented Mar 9, 2015

published @ https://iojs.org/dist/latest/

ping @iojs/website

@rvagg rvagg closed this as completed Mar 9, 2015
@Fishrock123
Copy link
Contributor

Site updated.

@mscdex mscdex added the meta Issues and PRs related to the general management of the project. label Mar 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

No branches or pull requests

6 participants