Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when SSL handshake is done "secure" instead of "secureConnect" event is emitted #10644

Closed
jkryl opened this issue Jan 5, 2017 · 1 comment
Closed
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs. tls Issues and PRs related to the tls subsystem.

Comments

@jkryl
Copy link

jkryl commented Jan 5, 2017

  • Version: v4.6.1
  • Platform: SunOS
  • Subsystem: tls

Hit with node v4 but it seems to be the case even with the latest node version. According to documentation for TLSSocket, when TLS handshake is done, the socket should emit secureConnect event:

https://nodejs.org/api/tls.html#tls_event_secureconnect

However instead of "secureConnect" is emitted "secure" event:

https://github.com/nodejs/node/blob/master/lib/_tls_wrap.js#L603

Either the documentation or the code needs to be fixed.

@addaleax
Copy link
Member

addaleax commented Jan 5, 2017

This is a duplicate of #10555, so I’m closing this. Please feel free to follow that thread/ask questions there. :)

@addaleax addaleax closed this as completed Jan 5, 2017
@addaleax addaleax added duplicate Issues and PRs that are duplicates of other issues or PRs. tls Issues and PRs related to the tls subsystem. labels Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

No branches or pull requests

2 participants