Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spawnSync tests failed on arm64 in ci job #1035

Closed
shigeki opened this issue Mar 3, 2015 · 9 comments
Closed

spawnSync tests failed on arm64 in ci job #1035

shigeki opened this issue Mar 3, 2015 · 9 comments
Labels
child_process Issues and PRs related to the child_process subsystem.

Comments

@shigeki
Copy link
Contributor

shigeki commented Mar 3, 2015

spawnSync tests on arm64 in ci job were failed with TIMEOUT in
https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/nodes=iojs-armv8-ubuntu1404/234/console
and related tests using spawnSync were also failed as discussed in #1028 .

CC: @bnoordhuis

@shigeki shigeki added the child_process Issues and PRs related to the child_process subsystem. label Mar 3, 2015
@jbergstroem
Copy link
Member

Suggesting we introduce a helper in common.js that allows tests to skip if crypto isn't available?

@shigeki
Copy link
Contributor Author

shigeki commented Mar 3, 2015

We've already done it in some crypto tests such as https://github.com/iojs/io.js/blob/v1.x/test/parallel/test-crypto.js#L5-L10

@jbergstroem
Copy link
Member

Oh, didn't know that. Well, lets expand that then?

Edit: how about https://gist.github.com/jbergstroem/eeec8cef7a37294ba580? If the entire file is affected, we just check and process.exit() - similar to what's found in test-crypto.js.

@brendanashworth
Copy link
Contributor

@jbergstroem +1 for that, keeping the code DRY, but lets use a Getter for that so v8 doesn't have to reload the crypto module for each test regardless of whether it is used (800 times).

@jbergstroem
Copy link
Member

Ok, I'll do a PR.

@shigeki
Copy link
Contributor Author

shigeki commented Mar 3, 2015

Some tls tests have another kind of checks as https://github.com/iojs/io.js/blob/v1.x/test/parallel/test-tls-0-dns-altname.js#L1-L4 . I'm not sure which one is better but the current tests which depends on configure library should be reconsidered.

@jbergstroem
Copy link
Member

Regardless check, we should at least mark all tests as skippable. I'll start by doing a common check and go through all tests looking for tls/crypto/anything else I can find.

@shigeki
Copy link
Contributor Author

shigeki commented Mar 25, 2015

The issue of the timeout errors in spawnSync tests on armv8 seems to be caused by libuv and resolved by shigeki@c60d978. The CI of https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/nodes=iojs-armv8-ubuntu1404/372/ showed only one error regarding a debug port.

@rvagg Can I make libuv tests on armv8 with Jenkins?

@shigeki
Copy link
Contributor Author

shigeki commented Apr 8, 2015

Fixed by #1365 . Thanks @bnoordhuis

@shigeki shigeki closed this as completed Apr 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem.
Projects
None yet
Development

No branches or pull requests

3 participants