From ff92b40ffcb5f61579f08f95a3586953983bf206 Mon Sep 17 00:00:00 2001 From: Tim Perry <1526883+pimterry@users.noreply.github.com> Date: Mon, 20 Feb 2023 21:10:29 +0100 Subject: [PATCH] http: close the connection after sending a body without declared length Previously, if you removed both content-length and transfer-encoding headers, the connection would still be kept-alive by default. This isn't helpful, because without those headers, the only way the client knows when the body is completed is when the connection closes. See https://www.rfc-editor.org/rfc/rfc7230#section-3.3.3 for more details on this message body handling logic (this is case 7). This meant that in effect, if you removed both headers every response came with a 5 second delay at the end (the default KA timeout) before the client could process it. Now, if you remove both headers the connection closes automatically immediately, so the client knows that it has received the whole message body. PR-URL: https://github.com/nodejs/node/pull/46333 Reviewed-By: Robert Nagy Reviewed-By: Matteo Collina Reviewed-By: Paolo Insogna --- lib/_http_outgoing.js | 4 ++++ test/parallel/test-http-remove-header-stays-removed.js | 9 +++++++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/lib/_http_outgoing.js b/lib/_http_outgoing.js index ea3d7e62556212..ae62e62c5671b7 100644 --- a/lib/_http_outgoing.js +++ b/lib/_http_outgoing.js @@ -548,6 +548,10 @@ function _storeHeader(firstLine, headers) { // Transfer-Encoding are removed by the user. // See: test/parallel/test-http-remove-header-stays-removed.js debug('Both Content-Length and Transfer-Encoding are removed'); + + // We can't keep alive in this case, because with no header info the body + // is defined as all data until the connection is closed. + this._last = true; } } diff --git a/test/parallel/test-http-remove-header-stays-removed.js b/test/parallel/test-http-remove-header-stays-removed.js index 3885ebd905f758..92c1e45dd25d01 100644 --- a/test/parallel/test-http-remove-header-stays-removed.js +++ b/test/parallel/test-http-remove-header-stays-removed.js @@ -37,8 +37,6 @@ const server = http.createServer(function(request, response) { response.setHeader('date', 'coffee o clock'); response.end('beep boop\n'); - - this.close(); }); let response = ''; @@ -57,5 +55,12 @@ server.listen(0, function() { res.on('data', function(chunk) { response += chunk; }); + + setTimeout(function() { + // The socket should be closed immediately, with no keep-alive, because + // no content-length or transfer-encoding are used: + assert.strictEqual(res.socket.closed, true); + server.close(); + }, 10); }); });