src: guard against calling Init() multiple times

This function should only be called once. Calling it multiple times would currently break Node.js (e.g. re-registering builtin modules would break the linked list for them). PR-URL: #26458 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Mar 13, 2019 · feb3a84 · feb3a84
1 parent bda41d8
commit feb3a84
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/node.cc b/src/node.cc
@@ -608,9 +608,14 @@ int ProcessGlobalArgs(std::vector<std::string>* args,
   return 0;
 }
 
+static std::atomic_bool init_called{false};
+
 int Init(std::vector<std::string>* argv,
          std::vector<std::string>* exec_argv,
          std::vector<std::string>* errors) {
+  // Make sure Init() is called only once.
+  CHECK(!init_called.exchange(true));
+
   // Register built-in modules
   binding::RegisterBuiltinModules();