From fd0aded233dc1ad743adc5ca80faa4807c470228 Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Mon, 21 Oct 2019 08:46:34 -0700 Subject: [PATCH] src: allow inspector without v8 platform Embedders sometimes want to take control of V8 platform initialization themselves, so we wouldn't want to experience an error if NODE_USE_V8_PLATFORM was false necessarily. Instead, we can also gate it with HAVE_INSPECTOR to allow embedders to define that themselves and use Inspector without NODE_USE_V8_PLATFORM. PR-URL: https://github.com/nodejs/node/pull/30049 Reviewed-By: Anna Henningsen Reviewed-By: Minwoo Jung Reviewed-By: Joyee Cheung Reviewed-By: David Carlier Reviewed-By: Colin Ihrig Reviewed-By: Gireesh Punathil Reviewed-By: Anto Aravinth --- src/node_options.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/node_options.cc b/src/node_options.cc index ac44a758dc565d..8ec469d3ac3a99 100644 --- a/src/node_options.cc +++ b/src/node_options.cc @@ -27,10 +27,10 @@ std::shared_ptr cli_options{new PerProcessOptions()}; } // namespace per_process void DebugOptions::CheckOptions(std::vector* errors) { -#if !NODE_USE_V8_PLATFORM +#if !NODE_USE_V8_PLATFORM && !HAVE_INSPECTOR if (inspector_enabled) { errors->push_back("Inspector is not available when Node is compiled " - "--without-v8-platform"); + "--without-v8-platform and --without-inspector."); } #endif