From fce1a5198a89e8f62ea2d093e01971db46da9bf5 Mon Sep 17 00:00:00 2001 From: Ruben Bridgewater Date: Thu, 3 Oct 2019 02:56:18 +0200 Subject: [PATCH] domain: do not import util for a simple type check This removes `require('util')` from the `domain` module. There was only a single simple type check used from the `util` module which is now inlined instead. PR-URL: https://github.com/nodejs/node/pull/29825 Reviewed-By: Anna Henningsen Reviewed-By: Yongsheng Zhang --- lib/domain.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/domain.js b/lib/domain.js index 3dc56c179acaa1..697ef6d8aded8b 100644 --- a/lib/domain.js +++ b/lib/domain.js @@ -28,7 +28,6 @@ const { Object, Reflect } = primordials; -const util = require('util'); const EventEmitter = require('events'); const { ERR_DOMAIN_CALLBACK_NOT_AVAILABLE, @@ -207,7 +206,7 @@ Domain.prototype.members = undefined; Domain.prototype._errorHandler = function(er) { var caught = false; - if (!util.isPrimitive(er)) { + if ((typeof er === 'object' && er !== null) || typeof er === 'function') { Object.defineProperty(er, 'domain', { configurable: true, enumerable: false,