From fc67abd97ec899771dd944cd9e21eac8c7b3422a Mon Sep 17 00:00:00 2001 From: Colin Ihrig Date: Thu, 25 Jul 2024 08:12:41 -0400 Subject: [PATCH] test: mark 'test/parallel/test-sqlite.js' as flaky The current test is large and can time out. It should be split into multiple smaller tests as done in #54014. However, that approach appears to change GC behavior such that the database files are not cleaned up quickly enough on Windows. Forcing any unfinalized SQL statements to be GC'ed appears to fix the problem. Mark the original test as flaky until the necessary code changes are made. PR-URL: https://github.com/nodejs/node/pull/54031 Reviewed-By: Moshe Atlow Reviewed-By: Jake Yuesong Li Reviewed-By: Stefan Stojanovic Reviewed-By: Richard Lau --- test/parallel/parallel.status | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status index da93f6ca89ac83..831f543f8e01d2 100644 --- a/test/parallel/parallel.status +++ b/test/parallel/parallel.status @@ -19,6 +19,9 @@ test-fs-read-stream-concurrent-reads: PASS, FLAKY # https://github.com/nodejs/node/issues/52630 test-error-serdes: PASS, FLAKY +# https://github.com/nodejs/node/issues/54006 +test-sqlite: PASS, FLAKY + [$system==win32] # Windows on x86