Skip to content

Commit

Permalink
src: fix -Wmaybe-uninitialized compiler warning
Browse files Browse the repository at this point in the history
Turn the `strategy_` method pointer into an enum-based static dispatch.

It's both safer and more secure (no chance of method pointer corruption)
and it helps GCC see that the shift and suffix tables it's complaining
about are unused in single char search mode.

Fixes the following warning:

    ../src/string_search.h:113:30: warning:
    ‘search’ may be used uninitialized in this function [-Wmaybe-uninitialized]
         return (this->*strategy_)(subject, index);

Fixes: #26733
Refs: #31532
Refs: #31798
PR-URL: #31809
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
bnoordhuis authored and MylesBorins committed Mar 11, 2020
1 parent c3aa3e7 commit fa376f4
Showing 1 changed file with 27 additions and 8 deletions.
35 changes: 27 additions & 8 deletions src/string_search.h
Original file line number Diff line number Diff line change
Expand Up @@ -100,17 +100,29 @@ class StringSearch : private StringSearchBase {
CHECK_GT(pattern_length, 0);
if (pattern_length < kBMMinPatternLength) {
if (pattern_length == 1) {
strategy_ = &StringSearch::SingleCharSearch;
strategy_ = SearchStrategy::kSingleChar;
return;
}
strategy_ = &StringSearch::LinearSearch;
strategy_ = SearchStrategy::kLinear;
return;
}
strategy_ = &StringSearch::InitialSearch;
strategy_ = SearchStrategy::kInitial;
}

size_t Search(Vector subject, size_t index) {
return (this->*strategy_)(subject, index);
switch (strategy_) {
case kBoyerMooreHorspool:
return BoyerMooreHorspoolSearch(subject, index);
case kBoyerMoore:
return BoyerMooreSearch(subject, index);
case kInitial:
return InitialSearch(subject, index);
case kLinear:
return LinearSearch(subject, index);
case kSingleChar:
return SingleCharSearch(subject, index);
}
UNREACHABLE();
}

static inline int AlphabetSize() {
Expand Down Expand Up @@ -149,10 +161,17 @@ class StringSearch : private StringSearchBase {
return bad_char_occurrence[equiv_class];
}

enum SearchStrategy {
kBoyerMooreHorspool,
kBoyerMoore,
kInitial,
kLinear,
kSingleChar,
};

// The pattern to search for.
Vector pattern_;
// Pointer to implementation of the search.
SearchFunction strategy_;
SearchStrategy strategy_;
// Cache value of Max(0, pattern_length() - kBMMaxShift)
size_t start_;
};
Expand Down Expand Up @@ -476,7 +495,7 @@ size_t StringSearch<Char>::BoyerMooreHorspoolSearch(
badness += (pattern_length - j) - last_char_shift;
if (badness > 0) {
PopulateBoyerMooreTable();
strategy_ = &StringSearch::BoyerMooreSearch;
strategy_ = SearchStrategy::kBoyerMoore;
return BoyerMooreSearch(subject, index);
}
}
Expand Down Expand Up @@ -548,7 +567,7 @@ size_t StringSearch<Char>::InitialSearch(
badness += j;
} else {
PopulateBoyerMooreHorspoolTable();
strategy_ = &StringSearch::BoyerMooreHorspoolSearch;
strategy_ = SearchStrategy::kBoyerMooreHorspool;
return BoyerMooreHorspoolSearch(subject, i);
}
}
Expand Down

0 comments on commit fa376f4

Please sign in to comment.