From f8c504245401b6f89690edcf5be05a8aef743619 Mon Sep 17 00:00:00 2001
From: Refael Ackermann <refack@gmail.com>
Date: Fri, 6 Apr 2018 17:55:50 -0400
Subject: [PATCH] tools: include exit code in TAP log

PR-URL: https://github.com/nodejs/node/pull/19855
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
---
 tools/test.py | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/tools/test.py b/tools/test.py
index 12ab9ab035c484..62457ec0717a6f 100755
--- a/tools/test.py
+++ b/tools/test.py
@@ -255,11 +255,12 @@ def HasRun(self, output):
 
 class TapProgressIndicator(SimpleProgressIndicator):
 
-  def _printDiagnostic(self, traceback, severity):
-    logger.info('  severity: %s', severity)
+  def _printDiagnostic(self):
+    logger.info('  severity: %s', self.severity)
+    self.exitcode and logger.info('  exitcode: %s', self.exitcode)
     logger.info('  stack: |-')
 
-    for l in traceback.splitlines():
+    for l in self.traceback.splitlines():
       logger.info('    ' + l)
 
   def Starting(self):
@@ -274,6 +275,7 @@ def HasRun(self, output):
     self._done += 1
     self.traceback = ''
     self.severity = 'ok'
+    self.exitcode = ''
 
     # Print test name as (for example) "parallel/test-assert".  Tests that are
     # scraped from the addons documentation are all named test.js, making it
@@ -285,7 +287,8 @@ def HasRun(self, output):
     if output.UnexpectedOutput():
       status_line = 'not ok %i %s' % (self._done, command)
       self.severity = 'fail'
-      self.traceback = "exit code: " + output.output.exit_code + "\n" + output.output.stdout + output.output.stderr
+      self.exitcode = output.output.exit_code
+      self.traceback = output.output.stdout + output.output.stderr
 
       if FLAKY in output.test.outcomes and self.flaky_tests_mode == DONTCARE:
         status_line = status_line + ' # TODO : Fix flaky test'
@@ -331,7 +334,7 @@ def HasRun(self, output):
     if self.severity is not 'ok' or self.traceback is not '':
       if output.HasTimedOut():
         self.traceback = 'timeout'
-      self._printDiagnostic(self.traceback, self.severity)
+      self._printDiagnostic()
     logger.info('  ...')
 
   def Done(self):