tools,lib: recommend using safe primordials

Make the linter recommend replacing `globalThis.Map` by `primordials.SafeMap`, and similar for `Set`, `WeakSet`, and `WeakMap`. PR-URL: #36026 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Shingo Inoue <[email protected]>
nodejs · Nov 10, 2020 · f8098c3 · f8098c3
1 parent 7a37590
commit f8098c3
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/lib/.eslintrc.yaml b/lib/.eslintrc.yaml
@@ -55,6 +55,7 @@ rules:
       into: Number
     - name: JSON
     - name: Map
+      into: Safe
     - name: Math
     - name: Number
     - name: Object
@@ -68,6 +69,7 @@ rules:
     - name: Reflect
     - name: RegExp
     - name: Set
+      into: Safe
     - name: String
     - name: Symbol
     - name: SyntaxError
@@ -78,7 +80,9 @@ rules:
     - name: Uint8ClampedArray
     - name: URIError
     - name: WeakMap
+      into: Safe
     - name: WeakSet
+      into: Safe
 globals:
   Intl: false
   # Parameters passed to internal modules

diff --git a/test/parallel/test-eslint-prefer-primordials.js b/test/parallel/test-eslint-prefer-primordials.js
@@ -77,6 +77,10 @@ new RuleTester({
         `,
         options: [{ name: 'Reflect' }],
       },
+      {
+        code: 'const { Map } = primordials; new Map()',
+        options: [{ name: 'Map', into: 'Safe' }],
+      },
     ],
     invalid: [
       {
@@ -154,5 +158,10 @@ new RuleTester({
         options: [{ name: 'Reflect' }],
         errors: [{ message: /const { ReflectOwnKeys } = primordials/ }]
       },
+      {
+        code: 'new Map()',
+        options: [{ name: 'Map', into: 'Safe' }],
+        errors: [{ message: /const { SafeMap } = primordials/ }]
+      },
     ]
   });