lib: make validateInternalField() throw ERR_INVALID_THIS

PR-URL: #58765
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Author: LiviaMedeiros

lib/internal/errors.js

@@ -1532,7 +1532,7 @@ E('ERR_INVALID_SYNC_FORK_INPUT',
   'Asynchronous forks do not support ' +
     'Buffer, TypedArray, DataView or string input: %s',
   TypeError);
-E('ERR_INVALID_THIS', 'Value of "this" must be of type %s', TypeError);
+E('ERR_INVALID_THIS', 'Value of "this" must be of type %s', TypeError, HideStackFramesError);
 E('ERR_INVALID_TUPLE', '%s must be an iterable %s tuple', TypeError);
 E('ERR_INVALID_TYPESCRIPT_SYNTAX', '%s', SyntaxError);
 E('ERR_INVALID_URI', 'URI malformed', URIError);

lib/internal/validators.js

@@ -24,6 +24,7 @@ const {
   codes: {
     ERR_INVALID_ARG_TYPE: { HideStackFramesError: ERR_INVALID_ARG_TYPE },
     ERR_INVALID_ARG_VALUE: { HideStackFramesError: ERR_INVALID_ARG_VALUE },
+    ERR_INVALID_THIS: { HideStackFramesError: ERR_INVALID_THIS },
     ERR_OUT_OF_RANGE: { HideStackFramesError: ERR_OUT_OF_RANGE },
     ERR_SOCKET_BAD_PORT: { HideStackFramesError: ERR_SOCKET_BAD_PORT },
     ERR_UNKNOWN_SIGNAL: { HideStackFramesError: ERR_UNKNOWN_SIGNAL },
@@ -526,9 +527,15 @@ const validateLinkHeaderFormat = hideStackFrames((value, name) => {
   }
 });
 
+/**
+ * Validate provided `this` object by checking that it has specific own property
+ * @param {any} object
+ * @param {string|symbol} fieldKey
+ * @param {string} className
+ */
 const validateInternalField = hideStackFrames((object, fieldKey, className) => {
   if (typeof object !== 'object' || object === null || !ObjectPrototypeHasOwnProperty(object, fieldKey)) {
-    throw new ERR_INVALID_ARG_TYPE('this', className, object);
+    throw new ERR_INVALID_THIS(className);
   }
 });
 

test/parallel/test-vm-module-basic.js

@@ -87,10 +87,7 @@ const util = require('util');
   for (const value of [null, { __proto__: null }, SourceTextModule.prototype]) {
     assert.throws(
       () => m[util.inspect.custom].call(value),
-      {
-        code: 'ERR_INVALID_ARG_TYPE',
-        message: /The "this" argument must be an instance of Module/,
-      },
+      { code: 'ERR_INVALID_THIS' },
     );
   }
 }

test/parallel/test-vm-module-errors.js

@@ -215,10 +215,7 @@ async function checkInvalidOptionForEvaluate() {
     ['link', 'evaluate'].forEach(async (method) => {
       await assert.rejects(async () => {
         await Module.prototype[method]();
-      }, {
-        code: 'ERR_INVALID_ARG_TYPE',
-        message: /The "this" argument must be an instance of Module/
-      });
+      }, { code: 'ERR_INVALID_THIS' });
     });
   }
 }
@@ -240,10 +237,7 @@ function checkInvalidCachedData() {
 }
 
 function checkGettersErrors() {
-  const expectedError = {
-    code: 'ERR_INVALID_ARG_TYPE',
-    message: /The "this" argument must be an instance of (?:Module|SourceTextModule)/,
-  };
+  const expectedError = { code: 'ERR_INVALID_THIS' };
   const getters = ['identifier', 'context', 'namespace', 'status', 'error'];
   getters.forEach((getter) => {
     assert.throws(() => {

test/parallel/test-vm-module-synthetic.js

@@ -69,10 +69,7 @@ const assert = require('assert');
   for (const value of [null, {}, SyntheticModule.prototype]) {
     assert.throws(() => {
       SyntheticModule.prototype.setExport.call(value, 'foo');
-    }, {
-      code: 'ERR_INVALID_ARG_TYPE',
-      message: /The "this" argument must be an instance of SyntheticModule/
-    });
+    }, { code: 'ERR_INVALID_THIS' });
   }
 
 })().then(common.mustCall());