Revert "os: move process.binding('os') to internalBinding"

This reverts commit 55d185f. PR-URL: #25446 Reviewed-By: Anna Henningsen <[email protected]>
nodejs · Jan 14, 2019 · f64e5ec · f64e5ec
1 parent 8cc9757
commit f64e5ec
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 9 deletions.
diff --git a/lib/internal/bootstrap/loaders.js b/lib/internal/bootstrap/loaders.js
@@ -87,7 +87,6 @@
     'icu',
     'js_stream',
     'natives',
-    'os',
     'pipe_wrap',
     'process_wrap',
     'signal_wrap',

diff --git a/lib/os.js b/lib/os.js
@@ -44,7 +44,7 @@ const {
   getUptime,
   isBigEndian,
   setPriority: _setPriority
-} = internalBinding('os');
+} = process.binding('os');
 
 function getCheckedFunction(fn) {
   return function checkError(...args) {

diff --git a/src/node_os.cc b/src/node_os.cc
@@ -467,4 +467,4 @@ void Initialize(Local<Object> target,
 }  // namespace os
 }  // namespace node
 
-NODE_MODULE_CONTEXT_AWARE_INTERNAL(os, node::os::Initialize)
+NODE_BUILTIN_MODULE_CONTEXT_AWARE(os, node::os::Initialize)
diff --git a/test/parallel/test-os-checked-function.js b/test/parallel/test-os-checked-function.js
@@ -1,11 +1,7 @@
 'use strict';
-// Flags: --expose_internals
-
-const { internalBinding } = require('internal/test/binding');
-
 // Monkey patch the os binding before requiring any other modules, including
 // common, which requires the os module.
-internalBinding('os').getHomeDirectory = function(ctx) {
+process.binding('os').getHomeDirectory = function(ctx) {
   ctx.syscall = 'foo';
   ctx.code = 'bar';
   ctx.message = 'baz';

diff --git a/test/parallel/test-process-binding-internalbinding-whitelist.js b/test/parallel/test-process-binding-internalbinding-whitelist.js
@@ -16,4 +16,3 @@ assert(process.binding('url'));
 assert(process.binding('spawn_sync'));
 assert(process.binding('js_stream'));
 assert(process.binding('buffer'));
-assert(process.binding('os'));