console: skip/strip %c formatting

Fixes: #29605 Refs: https://console.spec.whatwg.org PR-URL: #29606 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Sep 25, 2019 · f61c509 · f61c509
1 parent 6ba39d4
commit f61c509
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/doc/api/util.md b/doc/api/util.md
@@ -185,6 +185,9 @@ property take precedence over `--trace-deprecation` and
 <!-- YAML
 added: v0.5.3
 changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/29606
+    description: The `%c` specifier is ignored now.
   - version: v11.4.0
     pr-url: https://github.com/nodejs/node/pull/23708
     description: The `%d`, `%f` and `%i` specifiers now support Symbols
@@ -240,6 +243,8 @@ corresponding argument. Supported specifiers are:
 * `%O` - `Object`. A string representation of an object with generic JavaScript
   object formatting. Similar to `util.inspect()` without options. This will show
   the full object not including non-enumerable properties and proxies.
+* `%c` - `CSS`. This specifier is currently ignored, and will skip any CSS
+  passed in.
 * `%%` - single percent sign (`'%'`). This does not consume an argument.
 * Returns: {string} The formatted string
 

diff --git a/lib/internal/util/inspect.js b/lib/internal/util/inspect.js
@@ -1596,15 +1596,13 @@ function formatWithOptions(inspectOptions, ...args) {
               tempStr = inspect(args[++a], inspectOptions);
               break;
             case 111: // 'o'
-            {
               tempStr = inspect(args[++a], {
                 ...inspectOptions,
                 showHidden: true,
                 showProxy: true,
                 depth: 4
               });
               break;
-            }
             case 105: // 'i'
               const tempInteger = args[++a];
               if (typeof tempInteger === 'bigint') {
@@ -1623,6 +1621,10 @@ function formatWithOptions(inspectOptions, ...args) {
                 tempStr = formatNumber(stylizeNoColor, parseFloat(tempFloat));
               }
               break;
+            case 99: // 'c'
+              a += 1;
+              tempStr = '';
+              break;
             case 37: // '%'
               str += first.slice(lastPos, i);
               lastPos = i + 1;

diff --git a/test/parallel/test-util-format.js b/test/parallel/test-util-format.js
@@ -317,6 +317,12 @@ assert.strictEqual(util.format('abc%', 1), 'abc% 1');
 assert.strictEqual(util.format('%i', 1, 'number'), '1 number');
 assert.strictEqual(util.format('%i', 1, () => {}), '1 [Function]');
 
+// %c from https://console.spec.whatwg.org/
+assert.strictEqual(util.format('%c'), '%c');
+assert.strictEqual(util.format('%cab'), '%cab');
+assert.strictEqual(util.format('%cab', 'color: blue'), 'ab');
+assert.strictEqual(util.format('%cab', 'color: blue', 'c'), 'ab c');
+
 {
   const o = {};
   o.o = o;