Skip to content

Commit f2c1f36

Browse files
RamirezAlextargos
authored andcommitted
benchmark: swap var for let in util benchmarks
In benchmark util directory this changes for loops using var to let when it applies for consistency PR-URL: #28867 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Rich Trott <[email protected]>
1 parent 048db38 commit f2c1f36

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

benchmark/util/format.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ function main({ n, type }) {
2525
const [first, second] = inputs[type || 'string'];
2626

2727
bench.start();
28-
for (var i = 0; i < n; i++) {
28+
for (let i = 0; i < n; i++) {
2929
util.format(first, second);
3030
}
3131
bench.end(n);

benchmark/util/inspect-proxy.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ function main({ n }) {
99
const proxyA = new Proxy({}, { get: () => {} });
1010
const proxyB = new Proxy(() => {}, {});
1111
bench.start();
12-
for (var i = 0; i < n; i += 1)
12+
for (let i = 0; i < n; i += 1)
1313
util.inspect({ a: proxyA, b: proxyB }, { showProxy: true });
1414
bench.end(n);
1515
}

benchmark/util/inspect.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ const bench = common.createBenchmark(main, {
3030

3131
function benchmark(n, obj, options) {
3232
bench.start();
33-
for (var i = 0; i < n; i += 1) {
33+
for (let i = 0; i < n; i += 1) {
3434
util.inspect(obj, options);
3535
}
3636
bench.end(n);

benchmark/util/splice-one.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ function main({ n, pos, size }) {
2525
}
2626

2727
bench.start();
28-
for (var i = 0; i < n; i++) {
28+
for (let i = 0; i < n; i++) {
2929
spliceOne(arr, index);
3030
arr.push('');
3131
}

benchmark/util/type-check.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ function main({ type, argument, version, n }) {
4545
const arg = args[type][argument];
4646

4747
bench.start();
48-
for (var i = 0; i < n; i++) {
48+
for (let i = 0; i < n; i++) {
4949
func(arg);
5050
}
5151
bench.end(n);

0 commit comments

Comments
 (0)