Skip to content

Commit

Permalink
test: relax expectations in test-icu-transcode
Browse files Browse the repository at this point in the history
Chromium's ICU considers "latin1" and "ascii" to mean Windows-1252,
which is consistent with
[WHATWG spec](https://encoding.spec.whatwg.org/#names-and-labels). If
linked against Chromium's ICU, Node.js therefore fails
`test/parallel/test-icu-transcode`.

PR-URL: #25866
Refs: #25851
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
  • Loading branch information
hashseed authored and addaleax committed Feb 6, 2019
1 parent 2e80b91 commit ee3165d
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/parallel/test-icu-transcode.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@ if (!common.hasIntl)

const buffer = require('buffer');
const assert = require('assert');
const orig = Buffer.from('tést €', 'utf8');
const orig = Buffer.from('těst ☕', 'utf8');

// Test Transcoding
const tests = {
'latin1': [0x74, 0xe9, 0x73, 0x74, 0x20, 0x3f],
'latin1': [0x74, 0x3f, 0x73, 0x74, 0x20, 0x3f],
'ascii': [0x74, 0x3f, 0x73, 0x74, 0x20, 0x3f],
'ucs2': [0x74, 0x00, 0xe9, 0x00, 0x73,
'ucs2': [0x74, 0x00, 0x1b, 0x01, 0x73,
0x00, 0x74, 0x00, 0x20, 0x00,
0xac, 0x20]
0x15, 0x26]
};

for (const test in tests) {
Expand Down

0 comments on commit ee3165d

Please sign in to comment.