console: use consolePropAttributes for k-bind properties in constructor

PR-URL: #26850 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
nodejs · Mar 27, 2019 · ed5e69d · ed5e69d
1 parent 6342af7
commit ed5e69d
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/lib/internal/console/constructor.js b/lib/internal/console/constructor.js
@@ -181,15 +181,13 @@ Console.prototype[kBindProperties] = function(ignoreErrors, colorMode) {
       ...consolePropAttributes,
       value: Boolean(ignoreErrors)
     },
-    '_times': { ...consolePropAttributes, value: new Map() }
+    '_times': { ...consolePropAttributes, value: new Map() },
+    // Corresponds to https://console.spec.whatwg.org/#count-map
+    [kCounts]: { ...consolePropAttributes, value: new Map() },
+    [kColorMode]: { ...consolePropAttributes, value: colorMode },
+    [kIsConsole]: { ...consolePropAttributes, value: true },
+    [kGroupIndent]: { ...consolePropAttributes, value: '' }
   });
-
-  // TODO(joyeecheung): use consolePropAttributes for these
-  // Corresponds to https://console.spec.whatwg.org/#count-map
-  this[kCounts] = new Map();
-  this[kColorMode] = colorMode;
-  this[kIsConsole] = true;
-  this[kGroupIndent] = '';
 };
 
 // Make a function that can serve as the callback passed to `stream.write()`.