From ecadd638cd890a15098b2d4109529fcc55fed390 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Thu, 28 Mar 2024 17:50:22 +0000 Subject: [PATCH] deps: V8: remove references to non-existent flags https://github.com/nodejs/node/pull/49703 cherry-picked a commit from upstream V8 which references some maglev-related flags that are not present in the version of V8 in Node.js 20. PR-URL: https://github.com/nodejs/node/pull/52256 Reviewed-By: Joyee Cheung Reviewed-By: Luigi Pinca Reviewed-By: Jiawen Geng Reviewed-By: Marco Ippolito Reviewed-By: Rafael Gonzaga --- common.gypi | 2 +- deps/v8/src/flags/flags.cc | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/common.gypi b/common.gypi index efcd8da848150d..d05119d248223e 100644 --- a/common.gypi +++ b/common.gypi @@ -36,7 +36,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.19', + 'v8_embedder_string': '-node.20', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/src/flags/flags.cc b/deps/v8/src/flags/flags.cc index 78d7b82354cb04..ba5207f411bad4 100644 --- a/deps/v8/src/flags/flags.cc +++ b/deps/v8/src/flags/flags.cc @@ -586,10 +586,6 @@ uint32_t ComputeFlagListHash() { // The following flags are implied by --predictable (some negated). if (flag.PointsTo(&v8_flags.concurrent_sparkplug) || flag.PointsTo(&v8_flags.concurrent_recompilation) || -#ifdef V8_ENABLE_MAGLEV - flag.PointsTo(&v8_flags.maglev_deopt_data_on_background) || - flag.PointsTo(&v8_flags.maglev_build_code_on_background) || -#endif flag.PointsTo(&v8_flags.parallel_scavenge) || flag.PointsTo(&v8_flags.concurrent_marking) || flag.PointsTo(&v8_flags.concurrent_array_buffer_sweeping) ||